Skip to main content ↑ ↓

Show Posts

This section allows you to view all Show Posts made by this member. Note that you can only see Show Posts made in areas you currently have access to.

Messages - inkelyad

5
Simutrans-Extended closed bug reports / Average speed logic error?
Suppose we have just arrived convoy.
Code: [Select]
convoy.state = LOADING
somewhere.
Then laden() is called:
Code: [Select]
 case LOADING:
            laden();
Here
Code: [Select]
void convoi_t::laden() //"load" (Babelfish)
{
    //Calculate average speed
    //@author: jamespetts
    const uint32 journey_distance = accurate_distance(fahr[0]->get_pos().get_2d(), fahr[0]->last_stop_pos);

    const double journey_time = (welt->get_zeit_ms() - last_departure_time) / 4096.0F;
    const uint16 average_speed = ((double)journey_distance / journey_time) * 20.0;
    book(average_speed, CONVOI_AVERAGE_SPEED);
    last_departure_time = welt->get_zeit_ms();

    // Recalculate comfort
    book(get_comfort(), CONVOI_COMFORT);

    for(uint8 i = 0; i < anz_vehikel; i++)
    {
        // Accumulate distance 
        slist_iterator_tpl<ware_t> iter_cargo(fahr[i]->get_fracht());
        while(iter_cargo.next())
        {
            iter_cargo.access_current().add_distance(journey_distance);
        }
    }

All good.
But. When loading_level < loading_level => convoy.state (==LOADING) is not changed at exit. And all this will be called again.
So journey_time will be small (it just next cycle!), and average_speed will be very big. And it will be booked.

Maybe we need another state for this? (ARRIVED).
Edit: journey_distance for cargo will be added each time too.
8
Simutrans-Extended development / Re: [PATCH] Loading pattern for multiple convoys to the same destination.
Quote from: jamespetts – on
A question about this - will p****engers continue to pile into an overcrowded vehicle (thus compromising their comfort and therefore the player's profitability) if non-overcrowded vehicles are available?
Yes, they will. ( convoi_t::hat_gehalten try load convoy up to its max capacity)
Quote
Also, what happens if, during loading of one convoy, another convoy arrives which will reach the destination faster?
There was code to test this (see commented code in line 2362 of simhalt.cc, commit d5346d7c7a709c) but it was bad for some reason ( unwanted oscillations).
Quote
Perhaps this is of little relevance to p****engers in any event, as it is seldom sensible to set them to wait for a certain loading level; but perhaps overcrowding at least should be excluded from the loading queue?
It is not queue, technically. It works like this: remember in connexion where we loading. And if said convoy is still here, skip loading in current convoy.
10
Simutrans-Extended development / Re: How (not) to choose a route
Quote from: jamespetts – on
That is not correct: waiting time is destination dependent: see the "detail" display on the stations' dialogue boxes, which gives per-destination waiting and travelling times.
I don't understand. Said dialog box shows connexions.waiting_time field.
But all I can find is
path_explorer.cc:
Code: [Select]
new_connexion->waiting_time = halt_list[h]->get_average_waiting_time(halt_list[t], catg);
simhalt.cc:
Code: [Select]
new_connexion->waiting_time = get_average_waiting_time(current_halt, category);
It is not destination-specific.
11
Simutrans-Extended development / Re: How (not) to choose a route
Aha.
From haltestelle_t::add_connexion
Code: [Select]
connexion* existing_connexion = connexions[category]->get(current_halt);
if(existing_connexion->journey_time > new_connexion->journey_time)
{
    // The new connexion is better - replace it.
    delete existing_connexion;
    connexions[category]->set(current_halt, new_connexion);
}
James, i think waiting time must be used here too.
EDIT: sorry, it will not help. It looks like current rounting code allow only one active direct line D->C
12
Simutrans-Extended development / Re: How (not) to choose a route
If I understand code correctly, p****engers almost always choose faster route (not faster train). It includes waiting time and actual travel time. Sometimes they can wait for the next train to do it.

Worse, average waiting time is calculated over all p****engers at stop.
If at stop C you have long-waiting p****engers to somewhere else, then line 3 will be 'slow'.

13
Simutrans-Extended development / Re: Idea for next version.
It is possible,  but i don't want it. That way rivers will be just fancy roads. There must be difference between them. Anyway, this version is based on my earlier patch 'loading_queue' so ships should be loaded one after another and spread(somewhat) along the river because of it.
16
Pak128.Britain / Re: Request for artists: High-capacity barges.
Well, there is no real big rivers in real-life Britain, but we can have them in simutrans map => need for bigger barges.

About models: Something pretty generic. Just current steam/diesel model scaled to Seine Netter size will be enough.
20
Simutrans-Extended development / Different loading speed for different platforms.
Test release for Idea for next version. topic.
Github branch
Windows SDL file(patches.simutrans-germany.com)

Patch uses loading_time field from vehicle and level from platform to calculate actual loading time.
High-level platforms will decrease loading time.

If you define loading_speed_use_enables=1 somewhere in simuconf.tab, it will use 'enables' bit too.
After that, for example, p****enger-only platform will load goods(and mail!) very slowly.
22
Simutrans-Extended development / Re: Idea for next version.
Quote from: wlindley – on
Perhaps the "bulk goods loading tower" could have parameters that increase goods revenue and/or reduce loading time by, say, 20% (these would be cumulative; five of them would reduce loading time to .8^5 = 33%, not zero).
It is a bit too much. It must be simple:
Goods sliding can load 1000t per month VS Bulk goods loading tower can load 10000t per month.

Quote
...if we had hotels/restaurants they could multiply p****enger revenue and decrease loading time similarly.  And again cumulatively, if a restaurant increases p****enger revenue by 20%, then five of them would give you 1.2^5 = 2.5 times the revenue.
Restaurants: there is no need to touch revenue. Just make 'restaurants' industry chain.
Hotels: Extension building. It should increase 'storage capacity' for p****engers. Not decrease loading time. We will have advanced platform tiles for that.
23
Simutrans-Extended development / Re: Idea for next version.
'load_throughput[good_type]' in station tiles.
or just capacity define throughput via some global multiplier.

EDIT:
Or reuse 'level' for that and share throughput between all goods types (It have some kind of sense to do it).
26
Simutrans-Extended development / Re: Idea for next version.
Now load speed is not depends on platform tiles at all. One p****enger-enabled per halt allow load/unload p****enger on all platforms -- even 'bulk-load only'. And there is no difference in load speed between 'Goods sliding' and 'Bulk goods loading tower'.

Plaform lenght:
More tiles used -> more loading equipment -> loading should be faster.
28
Simutrans-Extended closed bug reports / [bug]? Station capacity calculation do not use 'capacity' field.

For sea-based stations 'capacity' field from dat file is used.
simhalt.cc, haltestelle_t::recalc_station_type()
Code: [Select]
if(gr->ist_w****er()) {
[SKIP]
                    if(besch->get_enabled()&1)
                    {
                        capacity[0] += besch->get_station_capacity();
                    }
                    if(besch->get_enabled()&2)
                    {
                        capacity[1] += besch->get_station_capacity();
                    }
                    if(besch->get_enabled()&4)
                    {
                        capacity[2] += besch->get_station_capacity();
                    }
                }
                else
                {
                    // no sperate capacities: sum up all
                    capacity[0] += besch->get_station_capacity();
                    capacity[2] = capacity[1] = capacity[0];
                }
            }
            continue;
        }
But for all other is not, it is level-based. (besch->get_level())
Code: [Select]
if(  welt->get_einstellungen()->is_seperate_halt_capacities()  ) {
            if(besch->get_enabled()&1) {
                capacity[0] += besch->get_level()*32;
            }
            if(besch->get_enabled()&2) {
                capacity[1] += besch->get_level()*32;
            }
            if(besch->get_enabled()&4) {
                capacity[2] += besch->get_level()*32;
            }
        }
        else {
            // no sperate capacities: sum up all
            capacity[0] += besch->get_level()*32;
            capacity[2] = capacity[1] = capacity[0];
        }
30
Simutrans-Extended development / Idea for next version.
Introduce loading/unloading throughput per cargo type for station tiles. That way we can have:
1) Longer platforms will be load/unload faster
2) Goods sliding/Goods sliding with Crane/Bulk goods loading tower/etc difference will not be purely cosmetic.
3) Ship transport will not be so cheat-like (no traffic jams, unlimited convoy capacity) as now.
34
Pak64.German Experimental / Re: pak.german-exp is now available for download
From main simutrans config/simuconf.tab:
Code: [Select]
# now river stuff
# first river type (should be defined in pak dependent file)
# The highest number is the smallest. A river with max_speed==0 is not navigavable by ships.
#river_type[0] = river
#river_type[1] = small_river
#river_type[2] = just_the source
From pak64 pak/config/simuconf.tab
Code: [Select]
# rivers:
# The highest number is the smallest. A river with max_speed==0 is not navigavable by ships.
river_type[0] = river
river_type[1] = river2
From openpak128/config/simuconf.tab
Code: [Select]
river_type[0] = river_00
river_type[1] = river_01
river_type[2] = river_02
river_type[3] = river_03
river_type[4] = river_04
From pak128.britain/config/simuconf.tab
Code: [Select]
river_type[0] = River3
river_type[1] = River2
river_type[2] = River1
river_type[3] = River0

See? You should define it too.
And use different image for canal. It is same as for river.