The International Simutrans Forum

Development => Patches & Projects => Incorporated Patches and Solved Bug Reports => Topic started by: z9999 on January 12, 2009, 08:03:14 pm

Title: [patch] Three type capacities for p****enger/mail/goods
Post by: z9999 on January 12, 2009, 08:03:14 pm
for http://forum.simutrans.com/index.php?topic=1040.msg11089#msg11089

The biggest problem will be that there is no way to enlarge post capacity in pak64 without building many post office.

- separate capacity for p****enger/mail/goods
- added capacity and freight type information to tooltips
- separate capacity value are also shown on station window

This patch includes "Show capacity and types on tooltips" patch.


[attachment deleted by admin]
Title: Re: [patch] Three type capacities for p****enger/mail/goods
Post by: VS on January 12, 2009, 08:16:36 pm
So plain platforms now give zero capacity?

(Any why is there a space invader as unhappy p****anger? :P )
Title: Re: [patch] Three type capacities for p****enger/mail/goods
Post by: z9999 on January 12, 2009, 08:31:56 pm
So plain platforms now give zero capacity?

Capacity of plain platforms is zero itself, if a station has no type.
But its capacities will be added to all p****enger/mail/goods types, if a station has that types.

So, plain platforms. airstops are still useful.
Title: Re: [patch] Three type capacities for p****enger/mail/goods
Post by: gerw on January 12, 2009, 08:53:55 pm
Nice idea for more detailed gameplay!

My suggestions:
1. In gui/halt_info.cc I would use a for-loop instead of coding the same stuff three times.
2. I think the changing in gui/karte.cc isn't optimal, since a stop overflooded with pax can still get an 'good color' if he have enough freight capacity.
3. Maybe you could also introduce a function haltestelle_t::get_ware_summe(ware_besch_t*), then the changing in simcity will also become nicer and more OOP like.
4. If you have a stop with freight capacity 32 you can store 32 of each freight type, at least factories will deliver their goods to the stop as long as each good is at the overall max. Is this intended?
Title: Re: [patch] Three type capacities for p****enger/mail/goods
Post by: jamespetts on January 12, 2009, 08:55:19 pm
Excellent improvement! Very good idea. And the same goes for your other patch along the same lines, too.
Title: Re: [patch] Three type capacities for p****enger/mail/goods
Post by: isidoro on January 13, 2009, 01:29:43 am
2. I think the changing in gui/karte.cc isn't optimal, since a stop overflooded with pax can still get an 'good color' if he have enough freight capacity.

Since RGB red + RGB green = RGB yellow,  why not make the color state the arithmetic average of the color states of all capacities of the station?
Title: Re: [patch] Three type capacities for p****enger/mail/goods
Post by: z9999 on January 13, 2009, 08:10:06 am
Thank you for many comments.

2. I think the changing in gui/karte.cc isn't optimal, since a stop overflooded with pax can still get an 'good color' if he have enough freight capacity.

If you want to see "overflooded" status, use "Stop status", not "Waiting". :)
"Waiting" is a relative scale to all waiting ware (HALT_WAITING).
Distributed should be dispersed well between min. and max.
So, it must use sum of capacities. This is the best, result of my test.
(In original simutrans, there are too many red.)

Quote
4. If you have a stop with freight capacity 32 you can store 32 of each freight type, at least factories will deliver their goods to the stop as long as each good is at the overall max. Is this intended?

I didn't touch this. So, this is intended.
If it will be changed, factories which have more than two productions don't work well, thus we must build separate station for each production.
Title: Re: [patch] Three type capacities for p****enger/mail/goods
Post by: prissi on January 14, 2009, 09:15:32 pm
In trunk, with an simuconf.tab setting:
ADD: (z9999) halt can have different storage capabilities for different good types (seperate_halt_capacities=1 in simuconf.tab)
Title: Re: [patch] Three type capacities for p****enger/mail/goods
Post by: wernieman on January 14, 2009, 09:57:47 pm
But it is not in the simuconf.tab wich is in the svn?
Title: Re: [patch] Three type capacities for p****enger/mail/goods
Post by: prissi on January 14, 2009, 10:44:36 pm
It is there too.