The International Simutrans Forum

Development => Patches & Projects => Incorporated Patches and Solved Bug Reports => Topic started by: gerw on May 15, 2009, 07:32:55 am

Title: [bug] r2458 Withdraw vehicle / line doesn't work.
Post by: gerw on May 15, 2009, 07:32:55 am
Vehicles are only selled, if empty and if they have stopped at an halt. So convoys without a halt in the schedule won't get selled. And empty convoys drive on, until they reach a station.
Title: Re: [bug] r2458 Withdraw vehicle / line doesn't work.
Post by: prissi on May 15, 2009, 09:08:32 am
THis is the intention of the withdraw button. Maybe additional an additional return home button that add one depot into all their schedules would be helpful too?
Title: Re: [bug] r2458 Withdraw vehicle / line doesn't work.
Post by: gerw on May 15, 2009, 09:17:16 am
Maybe additional an additional return home button that add one depot into all their schedules would be helpful too?
I don't think, this is helpful. Then you have to search your convoys in depots over the whole map.

I rather would move the 'withdraw code' from convoi_t::laden to an other position. Maybe a new function convoi_t::check_withdraw and call this function directly in convoi_t::step?

If you have a coal line, e.g., roughly one half of all convoys in this line are empty and thus can be sold immediately.
Title: Re: [bug] r2458 Withdraw vehicle / line doesn't work.
Post by: prissi on May 15, 2009, 09:25:49 am
Or just add the first check to set_withdraw() in convoi ...

But I would add only one depot, the one closes to the first stop for a return all button.
Title: Re: [bug] r2458 Withdraw vehicle / line doesn't work.
Post by: gerw on May 15, 2009, 11:16:36 am
But I would add only one depot, the one closes to the first stop for a return all button.
Then you will get trouble with choose signs.
Title: Re: [bug] r2458 Withdraw vehicle / line doesn't work.
Post by: prissi on May 15, 2009, 02:41:04 pm
Why: It will be introduced into all convois individual schedule. Then the convoi will get there (depot) next. Why should choose signs be important?
Title: Re: [bug] r2458 Withdraw vehicle / line doesn't work.
Post by: kierongreen on May 15, 2009, 04:47:23 pm
The whole point in withdrawing a vehicle is that it would wait until the next station and it was empty. This way no goods or p****engers are lost. Is it really that much of an issue that empty convoys go on - couldn't you just sell them directly instead?
Title: Re: [bug] r2458 Withdraw vehicle / line doesn't work.
Post by: prissi on May 15, 2009, 07:41:41 pm
They are already sold directly. I was just asking, why he dislike the return all (and put them in a single depot) option. This should be added too, to allow as much game styles as possible.
Title: Re: [bug] r2458 Withdraw vehicle / line doesn't work.
Post by: gerw on May 16, 2009, 08:48:01 am
Why: It will be introduced into all convois individual schedule. Then the convoi will get there (depot) next. Why should choose signs be important?
Ok, then I misunderstood you. If it is inserted in all schedules at the same position, then if works fine.