The International Simutrans Forum

Development => Patches & Projects => Incorporated Patches and Solved Bug Reports => Topic started by: wipi35 on July 01, 2009, 08:37:16 am

Title: Bug in vehicle window
Post by: wipi35 on July 01, 2009, 08:37:16 am
As can be seen in the appended screenshot the train is 100% loaded, but it says: 0/140 boxes of piece goods loaded.
These 140 boxes appear in the category refrigerated goods.
Using R2500 with Pak 128-579

http://simutrans-germany.com/files/upload/simscr13.png (http://simutrans-germany.com/files/upload/simscr13.png)
Title: Re: Bug in vehicle window
Post by: gerw on July 01, 2009, 09:28:34 am
Same as http://forum.simutrans.com/index.php?topic=2560.0 (http://forum.simutrans.com/index.php?topic=2560.0), but it seems that this bug isn't fixed. Can you provide a savegame?
Title: Re: Bug in vehicle window
Post by: wipi35 on July 01, 2009, 01:47:53 pm

I tried to upload at simutrans-germany.com but without success.
Don't understand why, savegame is 14MB, so smaller than max. filesize (20MB)
Title: Re: Bug in vehicle window
Post by: wipi35 on July 01, 2009, 03:10:09 pm
R2500 is from before June 27, so according to Prissi it should be fixed.
Title: Re: Bug in vehicle window
Post by: Zeno on July 01, 2009, 04:31:22 pm
I did report it in february, and it was solved few days later, according to this post (seems to be same problem):
http://forum.simutrans.com/index.php?topic=1478.0
Title: Re: Bug in vehicle window
Post by: gerw on July 01, 2009, 08:59:23 pm
The patch of this old topic was applied in r2363, so the bug still exists.
Title: Re: Bug in vehicle window
Post by: prissi on July 02, 2009, 09:52:36 am
Well, I need a savegame, because in my tests it did work as intended.
Title: Re: Bug in vehicle window
Post by: wipi35 on July 02, 2009, 01:44:49 pm
As I said, I tried to upload but without success. Is max. size of 20MB correct, the biggest file I see is 2.83 MB.
In the meantime I'm now using R2568 with Pak128-648 and I can't reproduce it anymore. So may be solved after all? I'll keep an eye on it.
Title: Re: Bug in vehicle window
Post by: gerw on July 02, 2009, 03:51:07 pm
Imho, the relevant code for this bug didn't changed since r2500. Is this version in the first post correct?
Title: Re: Bug in vehicle window
Post by: wipi35 on July 03, 2009, 11:22:23 am
Is this version in the first post correct?

Sure, it is.
Title: Re: Bug in vehicle window
Post by: gerw on July 03, 2009, 12:23:43 pm
I've found the problem:

Have a look at freight_list_sorter_t::sort_freight.

- full_list is sorted by simconvoi::get_freight_info in a very fancy way: by the smallest index a freight in this category has.
- but compare_ware sorts only by the index of the freights
=> wrong display.

With the patch, both sort according to the catg_index (which is unique, even for special freights). Also a savegame for testing purposes is attached.

http://www-user.tu-chemnitz.de/~gerw/patches/pics/convoi_info.sve (http://www-user.tu-chemnitz.de/~gerw/patches/pics/convoi_info.sve)
http://www-user.tu-chemnitz.de/~gerw/patches/convoi_info.patch (http://www-user.tu-chemnitz.de/~gerw/patches/convoi_info.patch)
Title: Re: Bug in vehicle window
Post by: wipi35 on July 03, 2009, 04:40:58 pm

My compliments!  :exclaim: