The International Simutrans Forum

Simutrans Extended => Simutrans-Extended development => Topic started by: Hanczar on July 26, 2009, 04:21:58 pm

Title: [bug v6.1] P****enger/mail convoi weird display
Post by: Hanczar on July 26, 2009, 04:21:58 pm
I create  convoy with bus and post trailer.
But after a while when open convoy display There appears two mail slots ( 1/25 mail and 0/25 mail )
Screenshot in attachment.

pak128, Simutrans 6.1
It very reproductive for me ( 4/4 ). This problem was introduced before 6.1, I saw it before, only I don't bother with it.


I saw similar problem about a week ago, when I load Yoshi big game to collect some profile data.
When I click on train with p****engers and mail wagons, it shows f.e 0/120 Mail loaded, but some bags with mails are displayed at end of p****enger list.
Screenshot done in current simutrans version in attachment.
pak64, Simutrans 6.1

In Simutrans-Standards such convoys displayed data correctly.


EDIT: images uploaded again ( thanks for reporting that they was broken ).
Title: Re: [bug v6.1] P****enger/mail convoi weird display
Post by: Michael 'Cruzer' on July 26, 2009, 04:37:38 pm
Could you upload the image again, beacuse there's an error in it?
Title: Re: [bug v6.1] P****enger/mail convoi weird display
Post by: jamespetts on July 30, 2009, 10:40:16 pm
Hmm, thank you for the report. Could you upload your saved game?
Title: Re: [bug v6.1] P****enger/mail convoi weird display
Post by: Hanczar on July 30, 2009, 11:41:23 pm
Here you go

pak 64, one train line, it has loaded mail and p****engers ( mail slot empty and mail bags at the end of p****enger list )
http://simutrans-germany.com/files/upload/pak64_train_with_p****enger_mail.sve (http://simutrans-germany.com/files/upload/pak64_train_with_p****enger_mail.sve)

pak 128, there is a bus line "(3) Line Pas" between Hereford and London, it has loaded only mail ( 2 mail slots are displayed after clicking on it ).
http://simutrans-germany.com/files/upload/p****enger_mail_convoy.sve (http://simutrans-germany.com/files/upload/p****enger_mail_convoy.sve)

Problem is reproducible every time for every convoy which transport p****enger and mail ( checked on buses and trains ).
If on such convoy has loaded only mail without p****engers -> display shows 2 mail slots.
If such convoy has loaded mail and p****engers -> display shows empty mail slot, and mails bags at the end of p****enger list.
Title: Re: [bug v6.1] P****enger/mail convoi weird display
Post by: Bernd Gabriel on July 31, 2009, 10:10:21 pm
@jamespetts: remember Topic: Load calculation problem
I think that I have solved this by partly reverting to some Simutrans-Standard code that I had previously removed because it appeared to cause crashes. However, I think that I have now fixed the crashes. The fix should be available in the next version (but will need the preprocessor directive SLIST_FREIGHT to be used).

Since I compile with SLIST_FREIGHT, which is missing in the .vcproj I downloaded from your branch, this bug has vanished.

@Hanczar
If you downloaded the source code and can compile it, set preprocessor directive SLIST_FREIGHT. Otherwize you might have to wait until James releases version 6.2.

Title: Re: [bug v6.1] P****enger/mail convoi weird display
Post by: Hanczar on August 01, 2009, 11:51:49 pm
Thanks a lot, adding SLIST_FREIGHT fixes this problem.

Problem without adding this option manually still  exist in 6.2. Can this option be enabled by default?
Title: Re: [bug v6.1] P****enger/mail convoi weird display
Post by: knightly on August 02, 2009, 04:46:43 pm

It seems that ST STD also uses SLIST now.
Title: Re: [bug v6.1] P****enger/mail convoi weird display
Post by: jamespetts on August 02, 2009, 04:50:31 pm
I think that Simutrans-Standard always did: I used a vector because I had problems with the SLIST at one time, although those seem to be cured now. I was going to enable the SLIST_FREIGHT precompiler directive for 6.2 to try to fix this bug, but forgot in the end.