The International Simutrans Forum

Development => Patches & Projects => Incorporated Patches and Solved Bug Reports => Topic started by: Frank on August 08, 2009, 11:50:35 am

Title: r2610 - diferent empty line
Post by: Frank on August 08, 2009, 11:50:35 am
In the info window from buildings missing empty line ( see grafics ).

(http://simutrans-germany.com/files/upload/Zwischenablage03.png)
Title: Re: r2610 - diferent empty line
Post by: Frank on January 03, 2010, 10:39:15 am
the patch added the emty line in citybuilding info windows

linebreak_citybuilding_info.diff (http://simutrans-germany.com/~patches/download.php?file=linebreak_citybuilding_info.diff)

(http://simutrans-germany.com/files/upload/emthy_line.png)
Title: Re: r2610 - diferent empty line
Post by: Dwachs on January 03, 2010, 11:57:08 am
thank you :) since the graphics of your original post were lost, the old bug report became useless.

in nightly revisino 2998.
Title: Re: r2610 - diferent empty line
Post by: prissi on January 03, 2010, 08:02:52 pm
Well this means mostly that the linebreak should be added on simutranslator. Or rather, just the field of the ownership should be empty as before.
Title: Re: r2610 - diferent empty line
Post by: Frank on January 03, 2010, 08:35:45 pm
Well this means mostly that the linebreak should be added on simutranslator. Or rather, just the field of the ownership should be empty as before.

Translator is not positive

tree info show the empty line
groundobj info show the empty line

citybuilding info show not empty line

add the line break to Translator then have tree and groundobj 2 line breaks and citybuilding 1 line break
Title: Re: r2610 - diferent empty line
Post by: prissi on January 03, 2010, 09:16:28 pm
Since buildings are most important trees and groundobj are imho wrong. Because an empty owner should omit it completely without a leading empty line.
Title: Re: r2610 - diferent empty line
Post by: Frank on January 03, 2010, 09:27:17 pm
 ???

(http://simutrans-germany.com/files/upload/Zwischenablage03.png)

string 'Kein Besitzer\n' in german

http://simutrans-germany.com/translator/script/edit.php?obj_id=35469&version=0&obj_type=program_text#de (http://simutrans-germany.com/translator/script/edit.php?obj_id=35469&version=0&obj_type=program_text&lang=de#de)
Title: Re: r2610 - diferent empty line
Post by: MHD on January 03, 2010, 10:26:21 pm
While working with translator I also observed strange behaviour of \n.
Sometimes, the breaks are not made and buildings like attractions then show up the whole text. This can leads to station names with prosaic text.

The breaks between owner and translator text should be alright in the case of building. As shown in Franks post, the missing line looks not good. Maybe, the placement within the window could be changed, so no text will follow up the owners' name.
Title: Re: r2610 - diferent empty line
Post by: Dwachs on January 04, 2010, 09:44:58 am
Would it help here to have the info window display html rather then text? Then these linebreak issues could be handled uniformly.

Maybe with a different translation string that describes the layout of the window (ie linebreaks defined by language).
Title: Re: r2610 - diferent empty line
Post by: prissi on January 04, 2010, 12:33:08 pm
Well the current version handles it consistently: No line break after the name for everything, allowing for empty string when stuff is not owned (which is mostly the case) ALso Streets are owned, but this was not printed priviously.
Title: Re: r2610 - diferent empty line
Post by: Frank on January 04, 2010, 06:55:39 pm
move them into the trash this thread

the simpler way is a failure

It was p****ed on to the translator, they need the \n in the translator if they want to add a blank line for their language


add 2 bytes ( 4 by utf-8 ) to string table for translate
Title: Re: r2610 - diferent empty line
Post by: prissi on January 04, 2010, 09:05:21 pm
The only other way would be to check if the translation is empty. If yes, add no newline, else add two.