The International Simutrans Forum

Development => Patches & Projects => Incorporated Patches and Solved Bug Reports => Topic started by: Fabio on August 25, 2009, 09:38:28 am

Title: [SOLVED BUG] No ground under fields
Post by: Fabio on August 25, 2009, 09:38:28 am
Last night i was testing a new factory for pak128 (a forest using trees as fields)
it's fields have no ground underneath, to match with the climate.
When i placed manually the factory, under the fields there was no ground (only that "transparency").
When i rotated once or more the map, the problem disappeared and the ground was correctly rendered.
Title: Re: [BUG] No ground under fields
Post by: The Hood on August 25, 2009, 09:42:21 am
I have reported this before - and would love it to be fixed.  Apparently it's not a bug though, fields don't currently support needs_ground properly...
Title: Re: [BUG] No ground under fields
Post by: Fabio on August 25, 2009, 10:33:01 am
but after rotating it works properly. i think it's more the need for a refresh
Title: Re: [BUG] No ground under fields
Post by: Dwachs on August 25, 2009, 11:42:55 am
When i placed manually the factory, under the fields there was no ground (only that "transparency").
This should be fixed in revision 2516.

Actuallly, fields are treated internally as if the parameter "needs_ground =1" was set, i.e. the ground under fields is always drawn (if no bugs are present).
Title: Re: [BUG] No ground under fields
Post by: Fabio on August 25, 2009, 12:02:05 pm
whops! i realised just now i was using an OLD version (March, i think) to test the factory. I'll try a newer one. so far, the bug should be closed. thanks.
Title: Re: [SOLVED BUG] No ground under fields
Post by: The Hood on August 25, 2009, 12:46:05 pm
I've still experienced the same behaviour in r2569 though...
Title: Re: [SOLVED BUG] No ground under fields
Post by: gerw on August 25, 2009, 12:58:41 pm
Dwachs mean, that it's fixed in 2615 :)

A little bit offtopic:
Where is gr->calc_bild() called, when the map is rotated? I searched it, but didn't find...
Title: Re: [SOLVED BUG] No ground under fields
Post by: The Hood on August 25, 2009, 01:07:00 pm
That would make sense then :)
Title: Re: [SOLVED BUG] No ground under fields
Post by: Dwachs on August 25, 2009, 01:09:10 pm
Where is gr->calc_bild() called, when the map is rotated? I searched it, but didn't find...

simwerkz.h, line 578, calls welt->update_map(), which does the job.

whops! i realised just now i was using an OLD version (March, i think) to test the factory. I'll try a newer one. so far, the bug should be closed. thanks.
After placing the factories and fields with map editor, the bug appears as you had described. The bug was also present in recent version, but is now fixed.