The International Simutrans Forum

Development => Patches & Projects => Incorporated Patches and Solved Bug Reports => Topic started by: prissi on October 10, 2009, 09:30:41 pm

Title: [WIP] settings direct configurable
Post by: prissi on October 10, 2009, 09:30:41 pm
I am working for some "advanced settings" where all the entries have the same name than their counterparts in the simuconf.tab and can be configured with gut. To make this not a bigger chore than neccessary, I use many defines and it is not as pretty as it could be. Here is a preview.
Title: Re: [WIP] settings direct configurable
Post by: sanna on October 10, 2009, 10:59:58 pm
Will the currently not enabled "Beginner mode" be on the new Settings dialogue?
Title: Re: [WIP] settings direct configurable
Post by: prissi on October 10, 2009, 11:46:17 pm
Or on the main screen ...
Title: Re: [WIP] settings direct configurable
Post by: z9999 on October 11, 2009, 02:58:18 am
Maybe you need to update Makefile too.

A screenshot attached.
Title: Re: [WIP] settings direct configurable
Post by: sojo on October 11, 2009, 06:53:21 am
Very nice, prissi. Good work. Go on!
Title: Re: [WIP] settings direct configurable
Post by: z9999+ on October 11, 2009, 06:54:48 am
This needs more tesing and hearing. Some comments, but not fully tested yet.

- station_coverage 1-7 is too small, some players want to use more larger value.
- default max_route_steps is 1000000, that is not under 32768. Value is not correct in settings window.
- 3 kinds of growthfactor should be more than 1, zero causes to crash.
Title: Re: [WIP] settings direct configurable
Post by: The Hood on October 11, 2009, 10:31:11 am
This is a great idea!  Keep up the good work.  Will it be possible one day to include "difficulty" settings in a dialogue like this?  E.g. vary base price of goods / different types of costs by x%?
Title: Re: [WIP] settings direct configurable
Post by: jamespetts on October 11, 2009, 10:55:20 am
This is a good development!
Title: Re: [WIP] settings direct configurable
Post by: prissi on October 11, 2009, 11:21:47 am
All the advance setting could be done in priciple. The dialoge could also get input from a savegame, and get the different settings that way ... And you are right about growth factors.

I just tweaked this morning to make everything more easier and consistent.

EDIT: Allowing for very large station coverages may give severe problems, since simutrans ****umes that not more than 256 stops could overlap. But 7 is already 225 tilesand 8 would be 289 tiles.
Title: Re: [WIP] settings direct configurable
Post by: jamespetts on October 11, 2009, 11:58:14 am
Might I make a suggestion about the GUI? Perhaps, instead of using the actual names from simuconf.tab as the text displayed by the individual settings, a translated string should be used for the text, but, a mouseover tooltip showing the actual simuconf.tab text could be displayed.
Title: Re: [WIP] settings direct configurable
Post by: VS on October 11, 2009, 12:00:15 pm
I guess it can all be translated later...
Title: Re: [WIP] settings direct configurable
Post by: prissi on October 11, 2009, 02:04:18 pm
One could use the string from the name as a tooltip. For display, I would like to use the name in simuconf.tab. Since the elements are now added by macros, tooltips are no problem (and even adding them only, if there is a translation is no problem).

Looking at the finished dialoge, it would make sence to make the climates a tab of this setting dialoge ...
Title: Re: [WIP] settings direct configurable
Post by: z9999+ on October 12, 2009, 04:00:28 am
Please allow to use zero to water_animation_ms, this eats CPU and this animation make us feel sickish, so many player using zero.

I'm always setting it to zero, but when I open settings window and close the window,
water animation will start. This is annoying.
Title: Re: [WIP] settings direct configurable
Post by: Fabio on October 12, 2009, 07:58:40 am
Lovely, i thought of this idea many, many times. ;D
It would be nice if the program could read every entry in simuconf.dat and let the player set it, this way whenever you add a new entry in simuconf the advanced settings would automatically include it.
Title: Re: [WIP] settings direct configurable
Post by: IgorEliezer on October 12, 2009, 12:50:55 pm
City categories: capitals, cities and villages. I always thought of posting this. What awesome!

Will pakset creators be able to choose on which city category a building will appear? For instance, I had made this Capitol (http://archive.forum.simutrans.com/topic/07334.0/index.html), I made it for the capitals. Buildings like a university, cathedrals, big monuments would appear only in capitals as well. A country house would appear in villages with a small growth rate. Villages that will look like a vilage; capitals looking like a capitals.

us (site down, do not visit) ]/image/show/HlCJWrq8C8/villagesfarms.gif](http://files.[ simutrans [dot] us (site down, do not visit) ]/image/thumb/HlCJWrq8C8/villagesfarms.gif) (http://files.[ simutrans [dot)

Title: Re: [WIP] settings direct configurable
Post by: Fabio on October 12, 2009, 01:03:48 pm
Will pakset creators be able to choose on which city category a building will appear?

this would be awesome! :P
Title: Re: [WIP] settings direct configurable
Post by: IgorEliezer on October 12, 2009, 01:12:53 pm
A new flag for dat file, similar to climate: city_category

Code: [Select]
city_category=capital,city,village
Title: Re: [WIP] settings direct configurable
Post by: The Hood on October 12, 2009, 01:43:48 pm
Is this city_category implemented?  That really would be awesome!  I think having some buildings reserved for certain types of city would add a lot more depth to the game. 
Title: Re: [WIP] settings direct configurable
Post by: IgorEliezer on October 12, 2009, 02:03:20 pm
I think having some buildings reserved for certain types of city would add a lot more depth to the game.

The good point is that urban landscape would be less repetitive. Seeing same building repeating in every city is not good (besides the buildings that don't fit in city size, like large cathedrals in a small town). This way, we will be inducing Simutrans to use a wider variety of buildings in an age.

EDIT:

The same could go to townhalls: big townhalls (max 4x4sq) for capitals; medium townhalls (max 2x2sq) for cities; and small ones (1x1sq) for villages. Such line-up could be decided by pak creator in dat.
Title: Re: [WIP] settings direct configurable
Post by: The Hood on October 12, 2009, 02:55:51 pm
Totally agree.  Except:

Quote
the buildings that don't fit in city size, like large cathedrals in a small town

Of course, in the UK we have to be awkward ;)

http://en.wikipedia.org/wiki/St_Davids (population 2,000)
http://en.wikipedia.org/wiki/Wells (population 10,000)
Title: Re: [WIP] settings direct configurable
Post by: wernieman on October 12, 2009, 03:18:40 pm
In Germany you have the same ...

At example Bardowick
http://en.wikipedia.org/wiki/Bardowick (http://en.wikipedia.org/wiki/Bardowick)
A very smal town, but have a very big church ..

(Better to see in the german WikipediaPage: http://de.wikipedia.org/wiki/Bardowick (http://de.wikipedia.org/wiki/Bardowick))
Title: Re: [WIP] settings direct configurable
Post by: colonyan on October 12, 2009, 08:52:46 pm

Can
"spawn industry at each X growth"
be added to the setting tab?
Seems like that one is missing in 2742.
Title: Re: [WIP] settings direct configurable
Post by: prissi on October 12, 2009, 09:59:33 pm
Since it is not in simuconf.tab, it is not yet included. Lets see.
Title: Re: [WIP] settings direct configurable
Post by: colonyan on October 13, 2009, 02:52:39 am
r2748-industry growth factor confirmed.
I guess this completes the setting list....
except when some player get to know how city grows and finds out they stop growing easily,
"minimum building per area" setting might come handy but that can be changed in simuconfig tab
since that setting can be changed even after the initial creation of the map.

So basicaly, once game is created, all setting cannnot be changed afterward except few others?
Title: Re: [WIP] settings direct configurable
Post by: z9999+ on October 13, 2009, 04:01:13 am
r2748 small problems

"Settings" in code but "Setting" in SimuTranslator
show_month 0-5 => 0-4 is correct.
citycar_level 1-1200 => Is this correct ? In display settings window or new map window, we can set only 0-16.

[EDIT]

pay_for_total_distance is missing.

And drive_left is missing but this won't be saved in savegame, so player must edit simuconf.tab anyway.

I think cost_signal, cost_tunnel, cost_third_rail had been obsoleted and no effects.
Title: Re: [WIP] settings direct configurable
Post by: prissi on October 13, 2009, 09:33:01 am
drive_left is not useful, as it must be set before a pakset is loaded, since it just shifts internally the images at load time. The other stuff will be corrected, that you.
Title: Re: [WIP] settings direct configurable
Post by: z9999+ on October 13, 2009, 10:20:10 am
drive_left is not useful, as it must be set before a pakset is loaded, since it just shifts internally the images at load time.

Oh, I didn't know that. Thank you for explaining it.  :)


[EDIT]
Thank you for fixing them.
One thing, text on new map window is still "Settings".
Title: Re: [WIP] settings direct configurable
Post by: z9999+ on October 14, 2009, 03:14:59 pm
Code: [Select]
Index: gui/welt.cc
===================================================================
--- gui/welt.cc (r 2764)
+++ gui/welt.cc (copy)
@@ -492,7 +492,7 @@
  use_intro_dates.set_text("Use timeline start year");
  allow_player_change.set_text("Allow player change");
 // use_beginner_mode.set_text("Beginner mode");
- open_setting_gui.set_text("Settings");
+ open_setting_gui.set_text("Setting");
  open_climate_gui.set_text("Climate Control");
  load_game.set_text("Load game");
  load_scenario.set_text("Load scenario");