The International Simutrans Forum

Development => Extension Requests => Topic started by: neroden on May 01, 2010, 02:16:49 am

Title: City monuments not listed in "attractions" list
Post by: neroden on May 01, 2010, 02:16:49 am
I'm not sure when this happened, but it's very annoying.  (Especially when I'm going "OK, where's a big monument in a city....")
Title: Re: City monuments not listed in "attractions" list
Post by: jamespetts on May 01, 2010, 03:33:38 pm
Neroden,

I have tested this, and the behaviour is identical in the latest nightly of Standard. I am therefore moving this to the standard development and bug reports section. Thank you for reporting!
Title: Re: City monuments not listed in "attractions" list
Post by: prissi on May 01, 2010, 07:21:24 pm
They were never listed ...
Title: Re: City monuments not listed in "attractions" list
Post by: neroden on May 02, 2010, 01:52:07 am

Huh.  You're right. I see your point.  :-)

In certain paks the monuments have very large p****enger counts (well, frankly even in pak64, but some paks are much more extreme) and it's useful to try to find cities with some/lots of them.  So I guess consider it a feature request.

I'm not quite sure what determines the difference between a "city attraction" and a "monument" in gameplay terms... perhaps some of the high-p****enger-count "monument"s in pak128.britain should be recl****ified as "city attractions" and that would be sufficient.

Anyway I discovered that not all monuments are getting properly listed in the *map editor* tools in pak128.britain-experimental, and they certainly should be listed *there*.  I guess that's a different bug.
Title: Re: City monuments not listed in "attractions" list
Post by: Dwachs on May 02, 2010, 09:57:19 am
I'm not quite sure what determines the difference between a "city attraction" and a "monument" in gameplay terms... perhaps some of the high-p****enger-count "monument"s in pak128.britain should be recl****ified as "city attractions" and that would be sufficient.
A monument is only built once on a map.
Title: Re: City monuments not listed in "attractions" list
Post by: prissi on May 02, 2010, 07:18:33 pm
In the map editor, only monuments which were not built yet should be listened.
Title: Re: City monuments not listed in "attractions" list
Post by: neroden on May 06, 2010, 06:28:46 pm
A monument is only built once on a map.

This is interesting!

They should definitely be listed in the "Attractions" list for gameplay purposes.  EDIT:  I'll try to make a patch, I bet I can do that.
EDIT 2: No, I can't find the right part of the code.  :(
Title: Re: City monuments not listed in "attractions" list
Post by: prissi on May 06, 2010, 08:32:45 pm
gui/tourist_frame.cc and -...stats.cc

And for building: attraction_edit.cc
Title: Re: City monuments not listed in "attractions" list
Post by: neroden on May 07, 2010, 01:12:35 am
Sadly those are not the places I couldn't figure out.  Is "denkmal" the same as "monument"?  I may have to do some translation before I can really figure out what's going on.