Development => Patches & Projects => Incorporated Patches and Solved Bug Reports => Topic started by: T0m4S on November 22, 2011, 05:10:26 pm
Title: [SOLVED] [bug r4954] Crahs loading savegames
Post by: T0m4S on November 22, 2011, 05:10:26 pm
Hi,
I just downloaded the last nightly version r4954 and since then I can't load anygames. It can start a new game and save it but not load it. The error is as following:
Title: Re: [bug r4954] Crahs loading savegames
Post by: DirrrtyDirk on November 22, 2011, 06:22:13 pm
Downloaded r4954? Hmmm I can still only see r4951 as the lastest when I call the nightly page... ???
I had to compile r4954 myself- and the error you describe did not happen to me. Saving, loading... old games, new games... all worked perfectly normal for me.
Title: Re: [bug r4954] Crahs loading savegames
Post by: T0m4S on November 22, 2011, 06:30:44 pm
I didn't downloaded it from the nightly site, but directly from the svn repository. So nobody else has the problem. :s
Title: Re: [bug r4954] Crahs loading savegames
Post by: DirrrtyDirk on November 22, 2011, 08:44:52 pm
Well, so far just I don't have it - and there are not that many people out there, who compile their own nightlies regularly (I also don't usually), I think (most probably download nightlies only from the nightly site).
Title: Re: [bug r4954] Crahs loading savegames
Post by: T0m4S on November 22, 2011, 09:07:28 pm
Yes, bad choice of words sorry... :-[ Actually I find it's strange that it refers to the file algorithm from MSCV 10, and at the line 3665 mentioned by the error there's:
Quote
// TEMPLATE FUNCTION sort WITH PRED template<cl**** _BidIt, cl**** _Pr, cl**** _Ty> inline void _Insertion_sort1(_BidIt _First, _BidIt _Last, _Pr _Pred, _Ty *) { // insertion sort [_First, _Last), using _Pred if (_First != _Last) for (_BidIt _Next = _First; ++_Next != _Last; ) { // order next element _BidIt _Next1 = _Next; _Ty _Val = _Move(*_Next);
if (_DEBUG_LT_PRED(_Pred, _Val, *_First)) { // found new earliest element, move to front _Move_backward(_First, _Next, ++_Next1); *_First = _Move(_Val); } else { // look for insertion point after first for (_BidIt _First1 = _Next1; _DEBUG_LT_PRED(_Pred, _Val, *--_First1); _Next1 = _First1) *_Next1 = _Move(*_First1); // move hole down *_Next1 = _Move(_Val); // insert element in hole } } }
Title: Re: [bug r4954] Crahs loading savegames
Post by: DirrrtyDirk on November 22, 2011, 09:20:35 pm
No need to be sorry. Just wanted to let you know, that just because it seems to work for me, does not mean there's no problem. But apparently, if there is one, it is not 100% reproducable. So solving might be a little tricky for the Devs.
Title: Re: [bug r4954] Crahs loading savegames
Post by: Dwachs on November 22, 2011, 09:21:20 pm
@Tomas: do you get similar error when rotating the map?
Edit: I think I know what the error is. The r4954 calls std::sort with a comparison function that is not a strict weak ordering... will fix this soon.
Title: Re: [bug r4954] Crahs loading savegames
Post by: T0m4S on November 22, 2011, 09:28:15 pm