The International Simutrans Forum

Development => Patches & Projects => Incorporated Patches and Solved Bug Reports => Topic started by: Frank on December 13, 2008, 07:23:18 am

Title: nightly r2161 - not used!
Post by: Frank on December 13, 2008, 07:23:18 am
compiled to MS VC++ 2005 EE

save to savegame is wrong

not load savegames to save this version

(http://www.simutrans-germany.com/files/upload/thumb_Zwischenablage01.jpg.jpg) (http://www.simutrans-germany.com/files/upload/Zwischenablage01.jpg)

http://www.simutrans-germany.com/files/upload/id-test.sve (http://www.simutrans-germany.com/files/upload/id-test.sve) pak64-svn


not load the language setting

not work 'simutrans.exe -singleuser'
Title: Re: nightly r2161 - not used!
Post by: z9999 on December 13, 2008, 03:33:39 pm
And many value are not initialized well.
Especially, bit per month sets to zero if there is no default.sve.

Extension request:
Please read settings value from text file(tab) as before, not from default.sve.
Binary file is not easy to customize for players.
Title: Re: nightly r2161 - not used!
Post by: prissi on December 13, 2008, 08:12:48 pm
But text file is also not easy when version changes. Also for OOP development, umgebung_t should take care of saving. (Text file is possible of course.)
Title: Re: nightly r2161 - not used!
Post by: z9999 on December 14, 2008, 08:13:30 am
Tested in r2165.
Many things are still not initialized well and also don't read player's settings.
For example, station_coverage, show_month etc.
Title: Re: nightly r2161 - not used!
Post by: prissi on December 14, 2008, 11:53:06 am
Please check again. (and delete sve before, since rdwr was canged)
Title: Re: nightly r2161 - not used!
Post by: z9999 on December 14, 2008, 12:25:23 pm
I did that way. station_coverage=0, show_month=0.
I tested both multiplayer and "singleuser_install = 0".

And also 'simutrans.exe -singleuser' still don't work.
If I start with '-singleuser',  bit_per_month=0. I can't play with it.


[edit]
Maybe, einstellungen_t::rdwr overwrite all config/simuconf.tab settings.
So, we must read config/simuconf.tab again after that, don't it ?

"multiuser" is also overwritten.
Title: Re: nightly r2161 - not used!
Post by: z9999 on December 14, 2008, 03:55:21 pm
way_leaving_road => way_leave_road

dataobj\einstellungen.cc:546
Code: [Select]
	way_count_leaving_road = contents.get_int("way_leaving_road", way_count_leaving_road);


=>
Code: [Select]
	way_count_leaving_road = contents.get_int("way_leave_road", way_count_leaving_road);




Sorry, this is off topic but my longtime question.
Why "singleuser_install=0" is singleuser mode and "singleuser_install=1" is multiuser mode ?  ???
I think this is just the opposite.
Title: Re: nightly r2161 - not used!
Post by: z9999 on December 15, 2008, 07:01:17 am
Tested in r2167 and no difference, still don't read config/simuconf.tab.
I don't know well, but I added simuconf.open before p****_simuconf, it read.
So, I think tabfile is closing or file pointer is wrong.

If you don't have any problem, this might be MinGW problem.

I don't know this code correct or not.
Code: [Select]
	// continue parsing ...
if(  found_simuconf  ) {
cstring_t obj_conf = umgebung_t::program_dir;
if(simuconf.open(obj_conf + "config/simuconf.tab")) {
umgebung_t::default_einstellungen.p****_simuconf( simuconf, disp_width, disp_height, fullscreen, umgebung_t::objfilename );
simuconf.close();
}
}



And "-singleuser" problem solved in this way.

simmain.cc:378
Code: [Select]
		multiuser = contents.get_int("singleuser_install", 1)==1;


=>
Code: [Select]
		multiuser = contents.get_int("singleuser_install", multiuser)==1;


Title: Re: nightly r2161 - not used!
Post by: z9999 on December 15, 2008, 10:20:59 am
There are two variables "electric_promille" and "default_electric_promille".

setze_electric_promille and gib_electric_promille() use "electric_promille", so default value of "Percent Electricity" on "New Map" window is zero.

dataobj\einstellungen.h
Code: [Select]
	void setze_electric_promille(sint32 d) {electric_promille=d;}
sint32 gib_electric_promille() const {return electric_promille;}



I don't know which is correct one.
Title: Re: nightly r2161 - not used!
Post by: z9999 on December 17, 2008, 03:55:59 pm
There are two variables "electric_promille" and "default_electric_promille".

Current status in r2170.

Value of "electric_promille" on simuconf.tab stores in "default_electric_promille".
"New map" window use "electric_promille".

So, value of "electric_promille" on simuconf.tab will be ignored.
Title: Re: nightly r2161 - not used!
Post by: Frank on December 27, 2008, 06:07:36 am
r2185

'simutrans -singleuser' work

load language settings work