[patch bugfix] Correct goods routing

Topic: [patch bugfix] Correct goods routing (Read 2551 times) previous topic - next topic

[patch bugfix] Correct goods routing

July 29, 2009, 11:38:37 am

This patch will fix two problems.
- We could transport goods from bus stop.
- When we removed a stop or an ext-stop, rebuild_destinations() wasn't called.

Re: [patch bugfix] Correct goods routing

Reply #1 – July 29, 2009, 11:59:01 am

Seeing cargo on a non-cargo-supporting bus stop on that screenshot made me wonder, is the fix
a) preventing cargo appearing on a bus stop since it doesn't support cargo or
b) preventing goods from being picked up on a bus stop tile?
I'd ****ume A. Not that B is a good thing either imo.

Re: [patch bugfix] Correct goods routing

Reply #2 – July 29, 2009, 01:49:21 pm

Is this somehow related to this old discussion:

http://forum.simutrans.com/index.php?topic=961.0 ?

So the patch is somehow semi-considered

Re: [patch bugfix] Correct goods routing

Reply #3 – July 29, 2009, 02:28:12 pm

Applied to trunk, thank you.

Re: [patch bugfix] Correct goods routing

Reply #4 – July 29, 2009, 03:47:28 pm

Sorry, prissi, your code is wrong.
If a convoi schedule is on tile A and I removed a stop on tile A.
This convoi becomes out of connection.
So, we must recalculate all schedule anyway.
It doesn't depend on enabled ware_type.

And also, I can't compile r2603, because of error.

Quote

===> CXX simhalt.cc
simhalt.cc: In static member function `static bool haltestelle_t::remove(karte_t*, spieler_t*, koord3d, const char*&)':
simhalt.h:213: error: invalid use of member `haltestelle_t::enables' in static member function
simhalt.cc:208: error: from this location
simhalt.h:213: error: invalid use of member `haltestelle_t::enables' in static member function
simhalt.cc:210: error: from this location
make: *** [simhalt.o] Error 1

Re: [patch bugfix] Correct goods routing

Reply #5 – July 29, 2009, 07:09:35 pm

should be corrected in 2604.