[r2637 and after GDI] Supplier on minimap window doesn't work well

Topic: [r2637 and after GDI] Supplier on minimap window doesn't work well (Read 2819 times) previous topic - next topic

[r2637 and after GDI] Supplier on minimap window doesn't work well

September 15, 2009, 07:06:01 pm

r2367 Windows GDI and after versions

Shift key doesn't seems to be recognized well.

How to reproduce:
- Open minimap window
- Click on "Factory details" button
- Press [Shift] key and mouse over a factory which has a supplier

Result:
Red line and supplier appears for just an instant, but will disapper.
Instead white line and consumer will appears. (for my case)
Another person reported that red line and supplier blinking fast.

Note:
- r2636 doesn't have this problem.
- Windows SDL version doesn't have this problem.

Re: [r2637 and after GDI] Supplier on minimap window doesn't work well

Reply #1 – September 16, 2009, 10:48:14 am

In fact SDL-version on Linux did not work properly for me too: Pressing 'shift' once shows supplier lines but could not be reverted to show consumers.

Do you have a suspection why 2636 works and 2637 not? The change between both revisions should have only affected ctrl-keys.

Here is a patch both for windows and sdl. I cannot test the windows part now (being on linux). I hope you can compile it.

It should now work this way: mouse-over factories with shift not pressed shows consumer, mouse-over with shift pressed shows supplier. Toggling shift-key without moving the mouse will not have an effect (and should be fixed later).

Or would you like to use the shift key like caps-lock: Pressing the key toggles between the to states? I have no idea how this feature used to be, since I discovered today that the shift key has an effect here

Re: [r2637 and after GDI] Supplier on minimap window doesn't work well

Reply #2 – September 16, 2009, 11:36:32 am

Thank you. This patch solved the problem on Windows GDI.
But I can't compile and test SDL version in my PC, sorry.

Re: [r2637 and after GDI] Supplier on minimap window doesn't work well

Reply #3 – September 22, 2009, 09:57:09 am

included in rev 2654