[patch] New convoi status FAHRPLANEINGABE

Topic: [patch] New convoi status FAHRPLANEINGABE_LOADING (Read 3426 times) previous topic - next topic

[patch] New convoi status FAHRPLANEINGABE_LOADING

August 20, 2009, 11:34:03 am

This patch adds a new convoi status FAHRPLANEINGABE_LOADING.
When schedule/line is changed, status of convoi which is loading will be FAHRPLANEINGABE_LOADING instead of FAHRPLANEINGABE. Which means that convoi knows last status was LOADING, thus convoi can continue to loading after changing its schedule/line if possible.

This will solve 3 problems below which will be happen after changing schedule/line.

- At airports or station with choose sign/signal, convoi will stop loading and move to scheduled position. This might cause deadlock with train.
- if convoi is moving on scheduled position, convoi stop at that position and start loading. So, convoi can't load 100%.
- If convoi is loading but is not on scheduled position, convoi move to scheduled position. This is ugly.

Re: [patch] New convoi status FAHRPLANEINGABE_LOADING

Reply #1 – August 20, 2009, 12:13:55 pm

Very nice idea. Maybe you can introduce functions like is_fahrplaneingabe() to avoid long statements as

Code: [Select]

state==convoi_t::FAHRPLANEINGABE  ||  state==convoi_t::FAHRPLANEINGABE_LOADING

Re: [patch] New convoi status FAHRPLANEINGABE_LOADING

Reply #2 – August 20, 2009, 01:22:17 pm

any chanche to have also dedicated images for loading vehicles?

Re: [patch] New convoi status FAHRPLANEINGABE_LOADING

Reply #3 – September 26, 2009, 06:21:45 pm

I think the patch by z9999 for getting the next position right, will also solve this issue.

Re: [patch] New convoi status FAHRPLANEINGABE_LOADING

Reply #4 – September 27, 2009, 05:43:38 am

Your patch is completely wrong.
Think why we need to think last state is loading or not.
I explained on the first post.

Quote from: z9999 – on August 20, 2009, 11:34:03 am

- if convoi is moving on scheduled position, convoi stop at that position and start loading. So, convoi can't load 100%.

[EDIT]
Bad news.
This patch completely doesn't work because of your another patch.

Re: [patch] New convoi status FAHRPLANEINGABE_LOADING

Reply #5 – September 27, 2009, 08:22:29 am

The state is loading can be checked in sync_step during FAHRPLANEINGABE as you did in your other patch correctly. Thus there is no need for the new state.

Re: [patch] New convoi status FAHRPLANEINGABE_LOADING

Reply #6 – September 27, 2009, 11:43:53 am

Quote from: prissi – on September 27, 2009, 08:22:29 am

The state is loading can be checked in sync_step during FAHRPLANEINGABE as you did in your other patch correctly. Thus there is no need for the new state.

No, it doesn't. It doesn't work like my patch.