Skip to main content ↑ ↓
Topic: [bug r2640] All stop report "Crowded" at new month (Read 4054 times) previous topic - next topic

[bug r2640] All stop report "Crowded" at new month

At the biginning of new month, I got "Overcrowded message" from all of stops.

Re: [bug r2640] All stop report "Crowded" at new month

Reply #1 –
Yes, somehow the overcrowded flag is not resetted at the beginning of a month.

Re: [bug r2640] All stop report "Crowded" at new month

Reply #2 –
No. overcrowded is a pointer that is not NULL.

   uint8 overcrowded[8];   // bit set, when overcrowded

   if(  welt->get_active_player()==besitzer_p  &&  overcrowded  ) {

Re: [bug r2640] All stop report "Crowded" at new month

Reply #3 –
Nobody seems to have a interest for this.
Then please revert the old correct code.

Code: [Select]
Index: simhalt.cc
===================================================================
--- simhalt.cc	(r 2643)
+++ simhalt.cc	(copy)
@@ -739,7 +739,7 @@
  */
 void haltestelle_t::neuer_monat()
 {
-	if(  welt->get_active_player()==besitzer_p  &&  overcrowded  ) {
+	if(  welt->get_active_player()==besitzer_p  &&  status_color == COL_RED  ) {
 		char buf[256];
 		sprintf(buf, translator::translate("!0_STATION_CROWDED"), get_name());
 		welt->get_message()->add_message(buf, get_basis_pos(),message_t::full, PLAYER_FLAG|besitzer_p->get_player_nr(), IMG_LEER );

Re: [bug r2640] All stop report "Crowded" at new month

Reply #4 –
I know what is wrong; however in colins save it reported stops crowded that where not, as also red color is obtained when p****engers are unhappy for routed over overcrowded stops. Those should be not reported. However, I cannot submit to svn at the moment, from this computer (on conference again).

Re: [bug r2640] All stop report "Crowded" at new month

Reply #5 –
Quote from: prissi – on
however in colins save it reported stops crowded that where not, as also red color is obtained when p****engers are unhappy for routed over overcrowded stops.

Thus, I didn't agree to add them to unhappy.  :-[

Anyway, current nightly has a problem which may open infomation windows as mucu as possible. This need to be fixd.

Re: [bug r2640] All stop report "Crowded" at new month

Reply #6 –
What about this:
Code: [Select]
	if(  welt->get_active_player()==besitzer_p  &&  (enables & CROWDED) ) {
but then everywhere, where a bit is set in overcrowded,
Code: [Select]
enables |= CROWDED;
must be added.

Also line 2176 looks weird:
Code: [Select]
				status_bits |= (ware_sum>max_ware+32  ||  CROWDED) ? 2 : 1;
as CROWDED=8, bool(CROWDED)=true, so the second test here makes no sense.

I do not have time to test this now :/
Parsley, sage, rosemary, and maggikraut.

Re: [bug r2640] All stop report "Crowded" at new month

Reply #7 –
Please solve the current problem first.
This old code had been used for many years without problems.
And current version has a big problem.

If you found a problem, think it freely after revert the code.

Re: r2640 : crowded bug

Reply #9 –
Should be fixed in newer releases. Was also found by z9999.