8.0 feedback

Topic: 8.0 feedback (Read 7803 times) previous topic - next topic

8.0 feedback

May 24, 2010, 04:32:32 am

crash:

Program received signal SIGSEGV, Segmentation fault.
0x0000000000498561 in std::__unguarded_linear_insert<ware_t*, ware_t, bool (*)(ware_t const&, ware_t const&)> (__last=0x496560, __val=..., 
    __comp=0x496560 <freight_list_sorter_t::compare_ware(ware_t const&, ware_t const&)>) at /usr/include/c++/4.4/bits/stl_algo.h:2086
2086		  *__last = *__next;
(gdb) bt
#0  0x0000000000498561 in std::__unguarded_linear_insert<ware_t*, ware_t, bool (*)(ware_t const&, ware_t const&)> (__last=0x496560, __val=..., 
    __comp=0x496560 <freight_list_sorter_t::compare_ware(ware_t const&, ware_t const&)>) at /usr/include/c++/4.4/bits/stl_algo.h:2086
#1  0x00007fffffffa5e0 in ?? ()
#2  0x00007fffffffa8e0 in ?? ()
#3  0x00007fffffffa5c0 in ?? ()
#4  0x00007fffffffa640 in ?? ()
#5  0x00000000004983b1 in std::__unguarded_insertion_sort<ware_t*, bool (*)(ware_t const&, ware_t const&)> (__first=0x496540, __last=0x7fffffffa8e8, 
    __comp=0x496560 <freight_list_sorter_t::compare_ware(ware_t const&, ware_t const&)>) at /usr/include/c++/4.4/bits/stl_algo.h:2161
#6  0x0000000000496560 in ?? ()
#7  0x00007fffffffa9c0 in ?? ()
#8  0x00007fffffffa8c0 in ?? ()
#9  0x0003002100000200 in ?? ()
#10 0x0000004a00450017 in ?? ()
#11 0x00007fff00000016 in ?? ()
#12 0x000000000026a604 in ?? ()
#13 0x0003000b00000100 in ?? ()
#14 0x00007fffffffa8e0 in ?? ()
#15 0x00007fffffffa670 in ?? ()
#16 0x0000000000498075 in std::__final_insertion_sort<ware_t*, bool (*)(ware_t c---Type <return> to continue, or q <return> to quit---
onst&, ware_t const&)> (__first=Cannot access memory at address 0x3000b000000f8
) at /usr/include/c++/4.4/bits/stl_algo.h:2194
Cannot access memory at address 0x3000b00000108

compiled it in 64 bit linux from james' master branch, tested it with pak196 comic.

Re: 8.0 feedback

Reply #1 – May 24, 2010, 08:14:54 am

Sdog,

thank you for the report. We've had some trouble with 64-bit compiles in the past - can you try to see whether it works with 32-bits?

Re: 8.0 feedback

Reply #2 – May 24, 2010, 06:00:50 pm

i couldn't reproduce the crash, with the same 64 bit binary. (apparently there was an autosave from just before the crash)

now i'll try everything again with your binaries, and report again.

Now testing with your binary: simutrans-exp-2010-05-24-c478903

'Public' and 'Default player' were mixed up. This happened with both paks comic and britain.
I worked around it by creating another player. i still receieved messages about overdrawing from the default player, when playing as new player.

I can reproduce the crash posted above with your 32 bit binary. To do so i have to switch player to this third player and click on any busstop. (owned by this player).

Code: [Select]

Program received signal SIGSEGV, Segmentation fault.
0x080ca109 in freight_list_sorter_t::compare_ware(ware_t const&, ware_t const&) ()
(gdb) bt
#0  0x080ca109 in freight_list_sorter_t::compare_ware(ware_t const&, ware_t const&) ()
#1  0x080cb557 in void std::__introsort_loop<ware_t*, int, bool (*)(ware_t const&, ware_t const&)>(ware_t*, ware_t*, int, bool (*)(ware_t const&, ware_t const&)) ()
#2  0x080ca66f in freight_list_sorter_t::sort_freight(vector_tpl<ware_t> const*, cbuffer_t&, freight_list_sorter_t::sort_mode_t, slist_tpl<ware_t> const*, char const*) ()
#3  0x081edca4 in haltestelle_t::get_freight_info(cbuffer_t&) ()
#4  0x0812a859 in halt_info_t::zeichnen(koord, koord) ()
#5  0x08236105 in display_win(int) ()
#6  0x082364bc in display_all_win() ()
#7  0x08236760 in win_display_flush(double) ()
#8  0x08200f58 in intr_refresh_display(bool) ()
#9  0x08243f9f in karte_t::sync_step(long, bool, bool) ()
#10 0x08200efc in interrupt_check(char const*) ()
#11 0x0824ec23 in karte_t::interactive(unsigned int) ()
#12 0x0820a663 in simu_main(int, char**) ()
#13 0x0828e751 in main ()

here's the pak version i used: http://www.simutrans-forum.de/forum/attachment.php?attachmentid=11066
and here's the savegame http://dl.dropbox.com/u/1876190/pak96.sve

I have m****ive urban sprawl, without higer level buildings or cities cores again. This happens even if large buildings are available. Tested with pak128.britain @1980, 1970, pak96.comic (w/o timeline), open.pak128 @ 1930, 1940, 1955, 1965. Disabling the new city generation did not change anything.

Re: 8.0 feedback

Reply #3 – May 24, 2010, 09:04:36 pm

Thank you very much for the report. I have tried this with your saved game and the linked version of Pak92.Comic and the Windows 32-bit release version, but cannot reproduce the bug (I get ****ert failures in an STD:: template in debug mode, but no adverse effects when they are ignored, and there are no ****ert failures when compiled as release). This looks to be potentially a Linux specific issue. Can any other Linux users confirm - especially 32-bit users so that we can see whether the problem is confined to 64 bit systems?

Re: 8.0 feedback

Reply #4 – May 26, 2010, 06:34:23 am

crash while quiting the game.

Code: [Select]

Program received signal SIGSEGV, Segmentation fault.
0x00000000 in ?? ()
(gdb) bt
#0  0x00000000 in ?? ()
#1  0x0808e0f3 in dingliste_t::get_convoi_vehicle() const ()
#2  0x08139033 in reliefkarte_t::calc_map_pixel(koord) ()
#3  0x08139ba2 in reliefkarte_t::calc_map() ()
#4  0x081bf3c7 in stadt_t::~stadt_t() ()
#5  0x08240884 in karte_t::rem_stadt(stadt_t*) ()
#6  0x08240b04 in karte_t::destroy() ()
#7  0x082458cb in karte_t::~karte_t() ()
#8  0x0820acd8 in simu_main(int, char**) ()
#9  0x0828e751 in main ()

used: your 32 bit binary, pak128.britain (with disabled simuconf.tab)

city creation works well when disabling pak128.britains simuconf.tab.
experienced some problems with tram tracks being transformed in grade crossings when city road gets updated due to city building updgrade.

Re: 8.0 feedback

Reply #5 – May 26, 2010, 10:05:45 pm

Code: [Select]

Program received signal SIGSEGV, Segmentation fault.
0x081b50bc in stadt_t::check_road_connexion_to(gebaeude_t const*) ()
(gdb) 
(gdb) bt
#0  0x081b50bc in stadt_t::check_road_connexion_to(gebaeude_t const*) ()
#1  0x081c2b7b in stadt_t::step_p****agiere() ()
#2  0x081c2da8 in stadt_t::step(long) ()
#3  0x0824e511 in karte_t::step() ()
#4  0x0824f2e0 in karte_t::interactive(unsigned int) ()
#5  0x0820a663 in simu_main(int, char**) ()
#6  0x0828e751 in main ()

crash while building a road
using: pak128.britain-experimental, simuconf.tab from your git repository, official 32bit binary

And another one, while trying to build a bridge with the drag tool:
EDIT: might be related to the bug described and fixed in this thread:
http://forum.simutrans.com/index.php?topic=5254.0

Code: [Select]

Program received signal SIGSEGV, Segmentation fault.
0x08066fa7 in wegbauer_t::calc_costs() ()
(gdb) bt
#0  0x08066fa7 in wegbauer_t::calc_costs() ()
#1  0x08228b54 in wkz_wegebau_t::mark_tiles(karte_t*, spieler_t*, koord3d const&, koord3d const&) ()
#2  0x0820e351 in two_click_werkzeug_t::move(karte_t*, spieler_t*, unsigned short, koord3d) ()
#3  0x08248047 in karte_t::bewege_zeiger(event_t const*) ()
#4  0x0824ec46 in karte_t::interactive(unsigned int) ()
#5  0x0820a663 in simu_main(int, char**) ()
#6  0x0828e751 in main ()

And one more, this time while toggling between different modes for the p****enger list of a station. e.g. via, via (amount), amount

Code: [Select]

Program received signal SIGSEGV, Segmentation fault.
0x080ca1c6 in freight_list_sorter_t::compare_ware(ware_t const&, ware_t const&)
    ()
(gdb) bt
#0  0x080ca1c6 in freight_list_sorter_t::compare_ware(ware_t const&, ware_t const&) ()
#1  0x080ca73c in freight_list_sorter_t::sort_freight(vector_tpl<ware_t> const*, cbuffer_t&, freight_list_sorter_t::sort_mode_t, slist_tpl<ware_t> const*, char const*) ()
#2  0x081edca4 in haltestelle_t::get_freight_info(cbuffer_t&) ()
#3  0x0812a859 in halt_info_t::zeichnen(koord, koord) ()
#4  0x08236105 in display_win(int) ()
#5  0x082364bc in display_all_win() ()
#6  0x08236760 in win_display_flush(double) ()
#7  0x08200f58 in intr_refresh_display(bool) ()
#8  0x08243f9f in karte_t::sync_step(long, bool, bool) ()
#9  0x08200efc in interrupt_check(char const*) ()
#10 0x0824ec23 in karte_t::interactive(unsigned int) ()
#11 0x0820a663 in simu_main(int, char**) ()
#12 0x0828e751 in main ()

Re: 8.0 feedback

Reply #6 – May 27, 2010, 06:30:55 pm

i found crash when you try making tunnels in split level mode eg you already have tunnel there and drag the track and it causes crash straightaway without a message telling me what is causing the problem - mine is 8.0 version with britain exp 0.6 (not sure how i find the britain exp pak version number)
and also the elevated trackways crashed the simtrans too - not sure what causing it

snapshot - http://yfrog.com/09undergroundcrashj
here when i try drag and its crashed - there was no error message after crash just standard error message
thanks

Re: 8.0 feedback

Reply #7 – May 29, 2010, 12:06:59 am

I can confirm the urban sprawl problem with the 32bit version on a 64bit system. After city generation with timeline from 1945 a city of 40k people took up half the screen at maximum zoom at 1920*1080.

Re: 8.0 feedback

Reply #8 – May 29, 2010, 06:26:58 am

I do get the urban sprawl, but not with every single map. I also get the "opposite" sometimes, cities that consist of only the city hall with surrounding streets, but not a single city building.

Re: 8.0 feedback

Reply #9 – May 29, 2010, 03:10:52 pm

You're right, I'm not getting urban sprawl maybe on 10 or 15% of map generations. I think I saw at least one of the cities without buildings, too.

Re: 8.0 feedback

Reply #10 – May 29, 2010, 10:17:44 pm

Thank you everyone for your feedback, and apologies for the delay in responding: I have just returned from holiday.

I am still away from the computer on which I develop Simutrans, but will look into the crashes when I get back. Can I ask - are the crashes reproducible or idiosyncratic? Is there a particular saved game that will always crash on quitting?

As to the sprawl - this should be solved by setting the "rennovation_percentage" to 33 in the Pak128.Britain-Ex simuconf.tab. I shall in due course release an updated version of Pak128.Britain-Ex for Simutrans 8.x, which will include this change, but, for the time being, editing the simuconf.tab file should produce the same result.

Thank you again for your feedback :-)

Re: 8.0 feedback

Reply #11 – May 29, 2010, 10:44:26 pm

Quote from: jamespetts – on May 29, 2010, 10:17:44 pm

Thank you everyone for your feedback, and apologies for the delay in responding: I have just returned from holiday.

I am still away from the computer on which I develop Simutrans, but will look into the crashes when I get back. Can I ask - are the crashes reproducible or idiosyncratic? Is there a particular saved game that will always crash on quitting?

As to the sprawl - this should be solved by setting the "rennovation_percentage" to 33 in the Pak128.Britain-Ex simuconf.tab. I shall in due course release an updated version of Pak128.Britain-Ex for Simutrans 8.x, which will include this change, but, for the time being, editing the simuconf.tab file should produce the same result.

Thank you again for your feedback :-)

the underground crashes are reproducible its occurs often

Re: 8.0 feedback

Reply #12 – May 29, 2010, 10:49:12 pm

I just tried on a brand new map to switch between the display mode (amount, via, etc.) on a station and for me it doesnt crash (32bit, running in gdb).

urban sprawl: I tried setting "rennovation_percentage" and "renovation_percentage" (had to create a new entry as there was no default one in there) in Pak128.Britain-Ex/config/simuconf.tab but it doesn't seem to have had any effect

Re: 8.0 feedback

Reply #13 – May 29, 2010, 11:20:05 pm

RSDWorker,

thank you for the feedback - I shall have to investigate that when I am in a position to look at the code again.

Steffen,

can you try also setting "quick_city_growth=0"?

Edit: I have just remembered: the "renovation_percentage" is in cityrules.tab, not simuconf.tab. Changing it there should have the desired effect.

Re: 8.0 feedback

Reply #14 – May 29, 2010, 11:52:45 pm

Quote from: jamespetts – on May 29, 2010, 11:20:05 pm

RSDWorker,

thank you for the feedback - I shall have to investigate that when I am in a position to look at the code again.

Steffen,

can you try also setting "quick_city_growth=0"?

Edit: I have just remembered: the "renovation_percentage" is in cityrules.tab, not simuconf.tab. Changing it there should have the desired effect.

thanks jamespotts

Re: 8.0 feedback

Reply #15 – May 30, 2010, 12:03:31 am

Quote from: jamespetts – on May 29, 2010, 11:20:05 pm

can you try also setting "quick_city_growth=0"?

Edit: I have just remembered: the "renovation_percentage" is in cityrules.tab, not simuconf.tab. Changing it there should have the desired effect.

quick_city_growth in the pak's simuconf.tab?

Edit: So far 6 of 7 were sprawled :/

Re: 8.0 feedback

Reply #16 – May 30, 2010, 12:25:24 am

should we just get the configs from github?

the crash on quiting occured only once, the others repeatedly.

The crash when deleting street occured always when i deleted a couple of cityroads.

i haven't tried the bridge building crash again.

the switching pasenger list occured twice, at different occasions. didn't have a savegame close enough to test it again.

Re: 8.0 feedback

Reply #17 – May 30, 2010, 10:46:08 am

The "quick_city_growth" setting can be set in either the pakset's or the master simuconf.tab - as with every simuconf.tab setting - but if there is a setting in the pakset's simuconf.tab, that will over-ride the master's setting. One can indeed obtain the configuration files from Github if one desires, although do bear in mind that they may be refined further before being released with the next version of the pakset.

As to the crashes - I shall have to investigate when I get a chance and see if I can find and fix the problems. Thank you again for your reports :-)

Re: 8.0 feedback

Reply #18 – May 30, 2010, 01:25:49 pm

Ok I tracked down the sprawl a little further, it only happens for a certain time period. If a make a game start 1929 or earlier its ok (well, I think density is lower than usual in the 1920s, but it doesn't go mad) or if I start a game in 1950 or later its also ok. Just those two decades in between it's being funny with me.

I also got the cycling crash once last night but I didn't have gdb running.

Re: 8.0 feedback

Reply #19 – May 30, 2010, 04:14:54 pm

Steffen,

ahh, in which case, the problem is not Simutrans-Experimental, but the lack of higher density buildings in the 1930s and 1940s in Pak128.Britain...

Re: 8.0 feedback

Reply #20 – May 30, 2010, 04:35:28 pm

Yep seems that way. Could you (temporarily?) extend a couple of higher density buildings into that timeframe?

Re: 8.0 feedback

Reply #21 – May 30, 2010, 05:41:35 pm

Hopefully by the time that the new version of Pak128.Britain-Ex is released, I'll have added one or two higher density buildings in that time-frame myself.

Re: 8.0 feedback

Reply #22 – June 02, 2010, 12:13:20 am

Quote from: sdog – on May 26, 2010, 10:05:45 pm

Code: [Select]

Program received signal SIGSEGV, Segmentation fault.
0x081b50bc in stadt_t::check_road_connexion_to(gebaeude_t const*) ()
(gdb) 
(gdb) bt
#0  0x081b50bc in stadt_t::check_road_connexion_to(gebaeude_t const*) ()
#1  0x081c2b7b in stadt_t::step_p****agiere() ()
#2  0x081c2da8 in stadt_t::step(long) ()
#3  0x0824e511 in karte_t::step() ()
#4  0x0824f2e0 in karte_t::interactive(unsigned int) ()
#5  0x0820a663 in simu_main(int, char**) ()
#6  0x0828e751 in main ()

crash while building a road
using: pak128.britain-experimental, simuconf.tab from your git repository, official 32bit binary

Sdog,

I can't reproduce this one, I'm afraid, using the debug version of the 32-bit Windows build. The backtrace indicates that the crash occurs in some new code that I added for 8.0 to check whether towns are connected to each other by road, and I'd expect that the method check_road_connexion_to would be called shortly after deleting or building a new road, but I'm not sure where the crash is coming from.

The other two crashes - the one involving dragging the bridge and the one relating to the freight list sorter - I'm hoping that I've managed to fix (if you can compile yourself, have a go with the 8.x branch on my Github repository), but this one I can't seem to trace at all, I'm afraid. Do you have a particular saved game in which it occurs?

Re: 8.0 feedback

Reply #23 – June 02, 2010, 03:00:56 am

sorry no savegames,

I can describe how it occured however: I was trying to generate a good map for a p****enger game and deleted a city merged with a larger one. After this there was still the deleted cities road network extant. I deleted it with the remove road tool, by deleting large portions of roads, bent and with many intersections.

In the first case the par where i deleted roads was partially sourrounded in an open C shaped manner by a larger city. The road at which it crashed connected both limbs of the C. It intersected with a road leading to a neighbouring city.

The other case was more open, the road was bent though. In both cases the street probably originated in the remaining city, moved over the deleted cities old terrain and ended in the remaining city.

If i got a moment, i'll try again if i can reproduce this crash.

Thanks for looking into the other crash reports, and fixing them.

Re: 8.0 feedback

Reply #24 – June 02, 2010, 11:36:03 pm

Sdog,

I think that I've found the issue: deleting the city was the key. I forgot to deal with the possibility of cities being deleted when I coded the system for checking road connexions. The issue is (hopefully) fixed on my 8.x branch on Github. Until 8.1 is released, I recommend not deleting cities (or, if you do delete a city, delete it while the game is paused, then immediately save and reload to avoid the crash).