Skip to main content ↑ ↓
Topic: [patch] vehikelbauer converts uint32 to sint32 (Read 3899 times) previous topic - next topic

[patch] vehikelbauer converts uint32 to sint32

If a vehicle costs 21M - 42M, the cast in vehikelbauer have a wrong result. This should be the 'bug' caused the cheat bus. Or is this the intended behaviour? ;)
Code: [Select]
Index: bauer/vehikelbauer.cc
===================================================================
--- bauer/vehikelbauer.cc       (revision 2589)
+++ bauer/vehikelbauer.cc       (working copy)
@@ -164,8 +164,8 @@
                        dbg->fatal("vehikelbauer_t::baue()", "cannot built a vehicle with waytype %i", vb->get_waytype());
        }
 
-       sp->buche(-(sint32)vb->get_preis(), k.get_2d(), COST_NEW_VEHICLE );
-       sp->buche( (sint32)vb->get_preis(), COST_****ETS );
+       sp->buche(-(sint64)vb->get_preis(), k.get_2d(), COST_NEW_VEHICLE );
+       sp->buche( (sint64)vb->get_preis(), COST_****ETS );
 
        return v;
 }

Re: [patch] vehikelbauer converts uint32 to sint32

Reply #1 –
The cheat bus is somehow accepted, although the conversion would be also ok.

Re: [patch] vehikelbauer converts uint32 to sint32

Reply #2 –
We could add a tool, which gives some money to the player - that would also ease the life of the AI  :D

Re: [patch] vehikelbauer converts uint32 to sint32

Reply #4 –
How to proceed now? Keep it as it is?

Re: [patch] vehikelbauer converts uint32 to sint32

Reply #5 –
The cheat bus seems to be accepted, thus the consent was aparently to keept thing like they are.

Re: [patch] vehikelbauer converts uint32 to sint32

Reply #6 –
Erm ... no one spoke up on this topic, so we should not jump to conclusions. I'd say we fix the bug, and the players have to use -freeplay, which was intended for money problems.

Re: [patch] vehikelbauer converts uint32 to sint32

Reply #7 –
I also don't like all those "intended bugs"...

Re: [patch] vehikelbauer converts uint32 to sint32

Reply #8 –
I agree with Hajo, it is a bug, there is a fix, if that fix is acceptable, then by all means apply it.

Re: [patch] vehikelbauer converts uint32 to sint32

Reply #9 –
I think way cost and way maintenance cost are also possible to earn money, if you set minus value.
 

Re: [patch] vehikelbauer converts uint32 to sint32

Reply #10 –
Quote from: z9999+ – on
I think way cost and way maintenance cost are also possible to earn money, if you set minus value.
Both are uint32, so no negative value possible. But it maybe depends on the 'long' type:
Code: [Select]
long get_preis() const { return price; }
long get_wartung() const { return maintenance; }

Re: [patch] vehikelbauer converts uint32 to sint32

Reply #11 –
There are two threds under Simutrans discussion and scenarios where this was discussed. If most people feel like this is needed I can apply it. I have no preferences on this topic.

Re: [patch] vehikelbauer converts uint32 to sint32

Reply #12 –
Try to wrote negative value in .dat file, so that you can see.

Re: [patch] vehikelbauer converts uint32 to sint32

Reply #13 –
Ok, added to trunk