[bug+fix?] Changing player while dragging

Topic: [bug+fix?] Changing player while dragging (Read 3339 times) previous topic - next topic

[bug+fix?] Changing player while dragging

October 23, 2009, 07:15:23 am

When you change the player (shift+P) while you are dragging with the waybuilder, there remains some leftovers on the map.
Fix:

Code: [Select]

Index: simworld.cc
===================================================================
--- simworld.cc	(revision 2821)
+++ simworld.cc	(working copy)
@@ -4836,6 +4836,9 @@
 		}
 	}
 	else {
+		// Exit the tool in order to get rid of leftovers.
+		werkzeug[active_player_nr]->exit( this, active_player );
+
 		renew_menu = (active_player_nr==1  ||  new_player==1);
 		active_player_nr = new_player;
 		active_player = spieler[new_player];

However, I'm not sure, if it causes the right behaviour in a network game...

Re: [bug+fix?] Changing player while dragging

Reply #1 – October 23, 2009, 07:56:56 am

No, this is not a good idea. I think it will be cleaned up, when you switch back (or at least it should). But one can think of doing this only in offline mode.

Re: [bug+fix?] Changing player while dragging

Reply #2 – October 23, 2009, 07:57:11 am

I have yet another cursor problem.
I'm not sure your patch will solve this problem too.

How to reproduce:
1. Start simutrans.
1. Click Inspecion tool icon on maion toolbar.
3. Press shift+P.

Result:
Zeiger remains.

Re: [bug+fix?] Changing player while dragging

Reply #3 – October 23, 2009, 07:58:58 am

In the current version, every player has its individual tool. Thus selecting a tool in one player and changing player should change to the last selected tool. This is an essential requirement for cooperative building on the map with the current structure of tools. Essentially SImutrans then handles up to 15 mousepointers ... (albeit only the active one should remain, that is indeed a bug.)

Re: [bug+fix?] Changing player while dragging

Reply #4 – October 24, 2009, 02:19:00 pm

Tested in r2823.
At least my problem still happen.

Re: [bug+fix?] Changing player while dragging

Reply #5 – October 25, 2009, 07:26:51 pm

Are you using allegro or the SDL version? And by Zeiger remains, do you mean the mouse pointer? I am not sure I got this correct.

Re: [bug+fix?] Changing player while dragging

Reply #6 – October 26, 2009, 05:56:07 am

Both GDI and SDL.

How to reproduce:
1. Close all windows and toolbars.
2. Open Railroad tools.
3. Close Railroad tools.
4. Press [Shift+P]

Re: [bug+fix?] Changing player while dragging

Reply #7 – October 30, 2009, 07:15:44 pm

@z9999: I can't reproduce your problem.

However the original problem in this thread remains: changing player while dragging leaves the bulldozer at the start position on the map. After changing back, one can continue dragging.

Re: [bug+fix?] Changing player while dragging

Reply #8 – October 30, 2009, 08:27:10 pm

That is intended. But if not desirable, we can use the above exit procedure.

Re: [bug+fix?] Changing player while dragging

Reply #9 – October 31, 2009, 01:21:19 pm

I think it is irritating to keep the bulldozer of the other player on the map. I would vote for the above exit procedure. Who wants to continue dragging after changing players multiple times anyway?