Skip to main content ↑ ↓
Topic: [cleanup patch] Speed variables to sint32. (Read 3542 times) previous topic - next topic

[cleanup patch] Speed variables to sint32.

Patch will change type of speed related variables to sint32.

Re: [cleanup patch] Speed variables to sint32.

Reply #1 –
Why did you change the type of ware_besch_t::get_speed_bonus() ? Imho, this variable is not a speed but rather a positive multiplicator of goods prices.

Edit: Incorporated in 3823 (without the change in ware_besch_t::get_speed_bonus).

Thank you!
Parsley, sage, rosemary, and maggikraut.
 

Re: [cleanup patch] Speed variables to sint32.

Reply #2 –
Debugging time.
Code: [Select]
#define SPEED_UNLIMITED ((std::numeric_limits<sint32>::max)())
Will give us big surprise in speed_to_kmh(SPEED_UNLIMITED).

Can we change it to something more sane? 1280000 (== 100000kmh)?

Re: [cleanup patch] Speed variables to sint32.

Reply #3 –
Why not. but how does this surprise affect the game?
Parsley, sage, rosemary, and maggikraut.

Re: [cleanup patch] Speed variables to sint32.

Reply #4 –

It is not problem in Standard. But it is in Experimental.
But it can be logic error somewhere. Leave it as is  then. I will find logic error.

Re: [cleanup patch] Speed variables to sint32.

Reply #5 –
If the bug is in the standard code, please report back / post your patch.
Parsley, sage, rosemary, and maggikraut.