[patch] factoryeditor gui: producer/consumer dependencies

Topic: [patch] factoryeditor gui: producer/consumer dependencies (Read 19444 times) previous topic - next topic

[patch] factoryeditor gui: producer/consumer dependencies

March 16, 2009, 10:13:55 pm

Hey folks,

I wrote a small patch which is IMO especially helpful for beginners.
It shows for a given factory f:
- A list of factories that produce the goods which are needed by f.
- A list of factories that consume the goods which are produced by f.

I have tested this patch with ubuntu linux with pak64: no known problems.

I'd like to make these lists clickable: If you click on a factory, it should be selected in the list on the left of the window.
BUT: The interface could be better in general. Maybe s.o. can help me out here.

There are two new translations ("factories producing " & "factories needing "), but I don't know were to add them (pak dependent?).
Is there a way to translate sentences? "factories producing X" would be "Fabriken, die X produzieren" in German.

smu42

[Edit: fixed tabs/spaces in patch]

Re: [patch] factoryeditor gui: producer/consumer dependencies

Reply #1 – March 16, 2009, 10:55:08 pm

Hi! Welcome to the forum.

As to the patch... Sorry, i am not very active programmer at the moment. The improvements look nice. As you say, interface could be better

Apart from clickable links, I think it might be good to allow hiding these texts (show on/off).

A side note - you use spaces for indenting, while the original code uses tabs. That is source of some changes listed in diff, while nothing changed on these lines.

Translations have to be added separately. Let's leave that for when it is decided to add this?

Re: [patch] factoryeditor gui: producer/consumer dependencies

Reply #2 – March 17, 2009, 04:45:04 am

My first version of map ediotr have had this.
But prissi removed this when merged in simutrans.

http://archive.forum.simutrans.com/topic/03405.0/index.html#msg60581

Re: [patch] factoryeditor gui: producer/consumer dependencies

Reply #3 – March 17, 2009, 11:19:46 am

Well, thats odd. But I think the main reason is the "bad interface" but not the idea. (Although z9999s gui was better than mine)

Prissi, if you don't like it this way, could you give me some hints? I'm not very good at designing interfaces, but I can certainly do the programming.

Ideas:
1) Hide/Show button. (simple implementation)
2) No texts. Add a filter filtering all factories which are supplier or consumer of f and show them in the window on the left. (a bit more complicated)
3) [insert your idea here]

Re: [patch] factoryeditor gui: producer/consumer dependencies

Reply #4 – March 23, 2009, 02:15:54 pm

Not sure, need to look more at the code. I certainly want to have the interface as less cluttered as possible. The information what factories can deliver is imho not most urgent, as generally the editor is only to be used for building scenarios and not during real games, as it will mess up the industry balance. This was the reason I left it out of the code. But zou are under considerated thus there is hope.

Chanching UI is time coonsuming, as those strings need to be put into svn and so on ...

Re: [patch] factoryeditor gui: producer/consumer dependencies

Reply #5 – March 23, 2009, 08:19:56 pm

Quote from: prissi – on March 23, 2009, 02:15:54 pm

Not sure, need to look more at the code.

I read that as "I will contact you, when I have detailed information"

Quote from: prissi – on March 23, 2009, 02:15:54 pm

I certainly want to have the interface as less cluttered as possible.

I agree. IMO the On/Off button is the best solution in that case.

Quote from: prissi – on March 23, 2009, 02:15:54 pm

The information what factories can deliver is imho not most urgent, as generally the editor is only to be used for building scenarios and not during real games, as it will mess up the industry balance.

I disagree. Yes, the info is not "most urgent" but very helpful.
There are also users that place each factory with this editor (I do this at least from time to time). It's just another way of playing simutrans.

Quote from: prissi – on March 23, 2009, 02:15:54 pm