[bugs] Underground slopes

Topic: [bugs] Underground slopes (Read 14431 times) previous topic - next topic

[bugs] Underground slopes

June 25, 2009, 08:13:55 am

The new underground slopes are a little bit buggy.

http://www-user.tu-chemnitz.de/~gerw/patches/pics/uslope1.png
You can build a flat route over a slope. Maybe it's due calc_straigt_route also tries the route backwards.

http://www-user.tu-chemnitz.de/~gerw/patches/pics/uslope2.png
You can build a way on top of an existing slope. (Last tile not checked?)

http://www-user.tu-chemnitz.de/~gerw/patches/pics/uslope3.png
Directly on top of a slope can be a flat tile.

http://www-user.tu-chemnitz.de/~gerw/patches/pics/uslope4.png
By combining the above bugs, a train can drive trough the floor...

In my opinion, building the slopes with the standard slope tools isn't very intuitive.

Re: [bugs] Underground slopes

Reply #1 – June 25, 2009, 06:54:35 pm

should be fixed in 2546.

Re: [bugs] Underground slopes

Reply #2 – June 25, 2009, 07:54:45 pm

Suddenly I cannot click on tiles below sea level. This needs to be changed. Thus I cannot built deeper than the grundw****er. Thus tunnel below the sea are not possible any more.

Re: [bugs] Underground slopes

Reply #3 – June 26, 2009, 07:01:19 am

Quote from: gerw – on June 25, 2009, 08:13:55 am

Directly on top of a slope can be a flat tile.

Isn't fixed. You can lower the tile after you built the slope.

Edit: Another (new) bug:
You can connect through a hang:
http://www-user.tu-chemnitz.de/~gerw/patches/pics/uslope5.png

Edit: Another (new) bug:
You can't built trams in street tunnels.

Re: [bugs] Underground slopes

Reply #4 – June 26, 2009, 07:42:00 am

Quote from: gerw – on June 26, 2009, 07:01:19 am

Edit: Another (new) bug:
You can't built trams in street tunnels.

do you have an idea, which change introduces this?

Re: [bugs] Underground slopes

Reply #5 – June 26, 2009, 07:46:36 am

After a short look, this should be due to "bd_von->get_weg_nr(0)->get_waytype() == besch->get_wtyp()".

Another bug: You can't build tunnels on top of other, flat tunnels. It's line 1336: It should also be possible if bd_von->get_weg_hang() == flach. (and also the same for the last tile).

Imho, the concept of the tunnel_ceilings would avoid many checks at different places...

Re: [bugs] Underground slopes

Reply #6 – June 26, 2009, 08:04:27 am

Quote from: gerw – on June 26, 2009, 07:01:19 am

Edit: Another (new) bug:
You can connect through a hang:
http://www-user.tu-chemnitz.de/~gerw/patches/pics/uslope5.png

should be fixed in 2551

Re: [bugs] Underground slopes

Reply #7 – June 26, 2009, 08:11:24 am

Can you check if these tram tunnels work correct directly after introducing sliced underground view?

Since the tram-builder does not call intern_calc_straight_route, which is only called for tunnels and if one uses ctrl+click for ways, I suspect this bug is around some more revisions.

Re: [bugs] Underground slopes

Reply #8 – June 26, 2009, 08:18:54 am

Should one be able to build tram on road tunnels with the normal way tool or with the tunnel tool?

Edit:
Back routes should be disabled for tunnels. Otherwise you will get strange results (or check, if the starting tile mathes):
http://www-user.tu-chemnitz.de/~gerw/patches/pics/uslope6.png

Re: [bugs] Underground slopes

Reply #9 – June 26, 2009, 08:38:17 am

rev. number?

tunnels on flat tunnels should be fixed, all-down-slopes on tunnel slopes tool in 2552.

However, terraforming with raise and lower (keys u and d) is not fixed.

Re: [bugs] Underground slopes

Reply #10 – June 26, 2009, 08:47:10 am

Quote from: Dwachs – on June 26, 2009, 08:38:17 am

rev. number?

This bug (uslope6) is also present in newest rev.

Quote

tunnels on flat tunnels should be fixed, all-down-slopes on tunnel slopes tool in 2552.

However, terraforming with raise and lower (keys u and d) is not fixed.

How about the tunnel_ceiling? With it, you will fix all those bugs with one 'klappe'.

Edit: Another bug, which would be easily fixed with the tunnel_ceiling (without any further code): 3d switches

http://www-user.tu-chemnitz.de/~gerw/patches/pics/uslope7.png

Re: [bugs] Underground slopes

Reply #11 – June 26, 2009, 09:03:42 am

Rev 2553 is my last commit on this subject.

And yes I feel an additional tunnel-ceiling ground object would have saved me some headaches.

Re: [bugs] Underground slopes

Reply #12 – June 26, 2009, 09:28:22 am

Quote from: gerw – on June 25, 2009, 08:13:55 am

In my opinion, building the slopes with the standard slope tools isn't very intuitive.

I strongly agree with Gerw on this. It would be clearer to players to have separate underground slope tools, than to add such functionality to the standard slope tools.

Re: [bugs] Underground slopes

Reply #13 – June 29, 2009, 06:50:19 am

Another bug: You can lower a way to the see.

And in the last rev (r2562) it isn't possible to build a way over an up slope.

Re: [bugs] Underground slopes

Reply #14 – June 29, 2009, 07:51:54 am

Code: [Select]

And in the last rev (r2562) it isn't possible to build a way over an up slope.

Sorry, do you mean underground or overground?

Re: [bugs] Underground slopes

Reply #15 – June 29, 2009, 08:38:40 am

Quote from: prissi – on June 29, 2009, 07:51:54 am

Sorry, do you mean underground or overground?

I mean underground. If you build an up slope, you can't extend the way on the upper level by just building over the up slope. It works fine with down slopes.

Re: [bugs] Underground slopes

Reply #16 – June 29, 2009, 08:40:38 pm

This is intended, as you could but a three way switch. Os am I misunderstanding you?

EDIT: Ok, understood and fixed this.

Re: [bugs] Underground slopes

Reply #17 – June 29, 2009, 08:53:38 pm

I don't know what you mean, but I think, you misunderstood me, too

The upper image shows what I'm doing and the lower one, what I expect, but what doesn't happen. More precise: nothing happens at all, if I click there.

Another bug: If I lower a canal, it doesn't get connected to the sea, which is the standard behaviour of canals.

Re: [bugs] Underground slopes

Reply #18 – June 30, 2009, 05:10:14 am

Why lowered should be connected automatically ?
Lowered is lowered, you need to connect manually, don't you ?

He may want to make a brigde.

Re: [bugs] Underground slopes

Reply #19 – June 30, 2009, 05:55:15 am

Problem in r2564.

Re: [bugs] Underground slopes

Reply #20 – June 30, 2009, 06:18:32 am

Quote from: z9999 – on June 30, 2009, 05:10:14 am

Why lowered should be connected automatically ?
Lowered is lowered, you need to connect manually, don't you ?

He may want to make a brigde.

That's true, but this wasn't possible with the old code. If you build a canal onto a down slope, it's get connected. So this two behaviours should be unified.

Edit:
Another bug: you can connect to other players rails in underground. This is really a 'hidden' feature

@prissi: What do you think of the tunnel_ceiling thing? In my opinion, this could save many checks - and frustrated programmers

Re: [bugs] Underground slopes

Reply #21 – June 30, 2009, 08:50:25 am

What of these stuff could be solved by tunnel ceiling? You could built ramps through bridges also with the old code overground, thus those checks for ground above/below are needed. The same stuff like you shown with the curve would be also not solved by a ceiling.

Re: [bugs] Underground slopes

Reply #22 – June 30, 2009, 09:11:17 am

Quote from: prissi – on June 30, 2009, 08:50:25 am

What of these stuff could be solved by tunnel ceiling?

Imho, the main point is lowering land above a tunnel slope. It also prevents that a way can be build on top of a slope. Of course, this can be done also by just checking, if there is a ground one height deeper. Do it as you want.

Quote

You could built ramps through bridges also with the old code overground

But only, if you build a bridge under an over. Imho, this should be forbidden anyway.

Re: [bugs] Underground slopes

Reply #23 – July 10, 2009, 05:42:29 am

which of these bugs are still in present in the most recent revision?

Re: [bugs] Underground slopes

Reply #24 – July 10, 2009, 06:41:30 pm

Quote from: Dwachs – on July 10, 2009, 05:42:29 am

which of these bugs are still in present in the most recent revision?

The 'Lower track to sea', the one with the canal, no trams in street tunnels, lower land above underground slope.

Maybe I forget one, I don't have a overview anymore.

Re: [bugs] Underground slopes

Reply #25 – July 10, 2009, 07:46:42 pm

Quote from: gerw – on July 10, 2009, 06:41:30 pm

The 'Lower track to sea', lower land above underground slope.

should be fixed in 2575

Quote

the one with the canal

is intended bugehavior ?

Re: [bugs] Underground slopes

Reply #26 – July 10, 2009, 08:32:09 pm

Here is a patch [incorporated in 2601] that allows
-- building tram tracks in road tunnels with the normal (non-tunnel) tram track tool
-- deleting of tram tracks on road tunnels, which is also broken. But I am not sure whether this change in grund.cc does not have unwanted consequences.

Moreover, the tram-track wayremover does not work. Would it be possible to internally treat the tram-track-remover as track remover but change only the tooltip?

Re: [bugs] Underground slopes

Reply #27 – July 14, 2009, 07:01:13 am

I found the texture under sea level missing though trains can go through the sea

●the entrances are at ground level.

●it went down 2 levels to the level under sea surface.
I was using r2576 + pak128 1.4.5

Re: [bugs] Underground slopes

Reply #28 – July 21, 2009, 07:04:26 pm

this is known. You can however use the sliced underground view, then you can see your undersea tunnels, if you change the underground level to undersea levels.