Skip to main content ↑ ↓
Topic: Bug in vehicle window (Read 4506 times) previous topic - next topic

Bug in vehicle window

As can be seen in the appended screenshot the train is 100% loaded, but it says: 0/140 boxes of piece goods loaded.
These 140 boxes appear in the category refrigerated goods.
Using R2500 with Pak 128-579

http://simutrans-germany.com/files/upload/simscr13.png

Re: Bug in vehicle window

Reply #2 –
Quote from: gerw – on
Can you provide a savegame?

I tried to upload at simutrans-germany.com but without success.
Don't understand why, savegame is 14MB, so smaller than max. filesize (20MB)
 

Re: Bug in vehicle window

Reply #3 –
R2500 is from before June 27, so according to Prissi it should be fixed.

Re: Bug in vehicle window

Reply #5 –
The patch of this old topic was applied in r2363, so the bug still exists.

Re: Bug in vehicle window

Reply #6 –
Well, I need a savegame, because in my tests it did work as intended.

Re: Bug in vehicle window

Reply #7 –
As I said, I tried to upload but without success. Is max. size of 20MB correct, the biggest file I see is 2.83 MB.
In the meantime I'm now using R2568 with Pak128-648 and I can't reproduce it anymore. So may be solved after all? I'll keep an eye on it.

Re: Bug in vehicle window

Reply #8 –
Imho, the relevant code for this bug didn't changed since r2500. Is this version in the first post correct?

Re: Bug in vehicle window

Reply #10 –
I've found the problem:

Have a look at freight_list_sorter_t::sort_freight.

- full_list is sorted by simconvoi::get_freight_info in a very fancy way: by the smallest index a freight in this category has.
- but compare_ware sorts only by the index of the freights
=> wrong display.

With the patch, both sort according to the catg_index (which is unique, even for special freights). Also a savegame for testing purposes is attached.

http://www-user.tu-chemnitz.de/~gerw/patches/pics/convoi_info.sve
http://www-user.tu-chemnitz.de/~gerw/patches/convoi_info.patch