[bugfix r2722] Citygrowth

Topic: [bugfix r2722] Citygrowth (Read 4273 times) previous topic - next topic

[bugfix r2722] Citygrowth

October 10, 2009, 04:37:33 am

Fixed
- values are not bool
- corrected growthfactor_small and growthfactor_large
- explanation: growthfactor=0 will cause crash, it is not no growth

Re: [bugfix r2722] Citygrowth

Reply #1 – October 10, 2009, 05:03:03 am

Quote from: z9999 – on October 10, 2009, 04:37:33 am

Fixed
- values are not bool
- corrected growthfactor_small and growthfactor_large
- explanation: growthfactor=0 will cause crash, it is not no growth

Oh wow! Thank you. Please hurry and release this. (If this is the answer to my problem, and I ****ume it is.)

WHOOPS!!!! Sorry I see you already have,

Re: [bugfix r2722] Citygrowth

Reply #2 – October 10, 2009, 05:14:29 am

@Colin
Sorry, this patch is not for your problem.
We still need to see your savegame to solve your problem. Thanks.

Re: [bugfix r2722] Citygrowth

Reply #3 – October 10, 2009, 10:41:17 am

Quote from: z9999 – on October 10, 2009, 05:14:29 am

@Colin
Sorry, this patch is not for your problem.
We still need to see your savegame to solve your problem. Thanks.

Oh ****! but strange, I haven't had the problem since installing r2722.

I can't seem to get any joy with the File Sharing site. It seems to accept the upload, tells me it's "Done" but doesn't put up a link and wont allow me to access the files page. Yet it logs me on ok.

Just as a matter of interest, what was the "City Growth" problem that r2722 was for? because I haven't experienced any other 'City Growth' problem other the one I reported.

Re: [bugfix r2722] Citygrowth

Reply #4 – October 10, 2009, 12:28:45 pm

Colin, z9999' patch is for r2722 - it's not in yet.
So when your problem is gone, it was corrected by something else (my guess is prissi's work for the problem of crashes with rotated maps - i.e. r2720).

Now to the other issues:

1) What file sharing site do you refer to?

2) r2722 wasn't made for a "City Growth" problem according to the SVN changelog.
since last nightly before (= r2718):

2719: "ADD: citygrowth parameter configurable in simuconf.tab"
2720: (Fix?) "crach when enlarging rotated maps"
2721: "New recalc natural slope routine for more natural slopes ..."
2722: "(Knightly) markers for faster search"

Re: [bugfix r2722] Citygrowth

Reply #5 – October 10, 2009, 12:49:46 pm

Quote from: DirrrtyDirk – on October 10, 2009, 12:28:45 pm

Colin, z9999' patch is for r2722 - it's not in yet.
So when your problem is gone, it was corrected by something else (my guess is prissi's work for the problem of crashes with rotated maps - i.e. r2720).

Now to the other issues:

1) What file sharing site do you refer to?

2) r2722 wasn't made for a "City Growth" problem according to the SVN changelog.
since last nightly before (= r2718):
2719: "ADD: citygrowth parameter configurable in simuconf.tab"
2720: (Fix?) "crach when enlarging rotated maps"
2721: "New recalc natural slope routine for more natural slopes ..."
2722: "(Knightly) markers for faster search"

Ok firstly. Are you actually saying that the patch was made for this revision but hasn't been incorporated into it? Previously I was using r2718, since loading r2722 I don't have the problem, or it hasn't occured again since then. So if r2722 has cured my City Growth problem, then I'm happy, wether it was intened or not.
2nd. http://simutrans-germany.com/files/upload.php?upload=true&lang=
3rd. If you read my previous posts, Rotation wasn't the problem.

Going to bed now Dirk so I may catch tomorrow.

Re: [bugfix r2722] Citygrowth

Reply #6 – October 10, 2009, 02:32:32 pm

Quote from: Colin – on October 10, 2009, 12:49:46 pm

Ok firstly. Are you actually saying that the patch was made for this revision but hasn't been incorporated into it?

Ok, let me rephrase it: z9999 found something wrong in the code of r2722 and wrote a patch for it. So yes, the patch is an update for a problem in the code of r2722 and is therefore not part of r2722 since it was written afterwards. (And as soon as something is done to the code and commited to the SVN-Server, the number automatically rises by one - currently the code is at r2725 (Dwachs did 3 new things today) and if prissi included z9999's patch at this moment, this would instantly create r2726. And werniemann's server just grabs the latest revision it can find each night and creates a nightly version from it.) Hope this clarifies things a bit.

Quote from: Colin – on October 10, 2009, 12:49:46 pm

Previously I was using r2718, since loading r2722 I don't have the problem, or it hasn't occured again since then. So if r2722 has cured my City Growth problem, then I'm happy, wether it was intened or not.

Sure, only the result is important. I only wanted to explain that whatever happened was not because of the patch presented in this thread -since it is not part of the nightly code yet.

Quote from: Colin – on October 10, 2009, 12:49:46 pm

2nd. http://simutrans-germany.com/files/upload.php?upload=true&lang=
3rd. If you read my previous posts, Rotation wasn't the problem.

Going to bed now Dirk so I may catch tomorrow.

2. Ok, that's on Frank's server - last time I tried, it worked for me, but I remember someone else also had trouble with it. Maybe the connection timed out or something like that... I think Frank needs to look into this himself. But what size of file are we talking about? Have you ever uploaded something successfully there?

3. Yes, for your problem rotation apparently wasn't the problem, but for the other problem it was. And whatever changes prissi made in the code might also have had an effect on your problem. After all, computers work 50% by logic and 50% by witchcraft

. The other changes don't sound (I'm only guessing by looking at the changelog entries, I have no clue about the code itself) like they could affect the situation - again it's just a not very educated guess.

Re: [bugfix r2722] Citygrowth

Reply #7 – October 10, 2009, 02:42:31 pm

Quote from: DirrrtyDirk – on October 10, 2009, 02:32:32 pm

But what size of file are we talking about? Have you ever uploaded something successfully there?

Sorry for interrupting your conversation with Colin, but since he is having sweet dreams right now, I think I can answer your questions on his behalf

His save game is ~16MB (He sent me a copy via email, so I know).
He has uploaded files successfully in the past, as I have downloaded some save games from him before, via the file sharing site.

Re: [bugfix r2722] Citygrowth

Reply #8 – October 10, 2009, 03:20:23 pm

Ok... (not that I couldn't have waited for Colin's return tomorrow

)

But 16MB is large enough that I think connection timeout might really be an issue here... and since he already used that site in the past, we can safely ****ume he knows how to do it (which, had it been his first time, could have been the reason: e.g. problems with the site's user interface or so...).

Well, IMHO that's definitely something for Frank to look into then.

Re: [bugfix r2722] Citygrowth

Reply #9 – October 10, 2009, 11:19:12 pm

Quote from: DirrrtyDirk – on October 10, 2009, 03:20:23 pm

Ok... (not that I couldn't have waited for Colin's return tomorrow )

But 16MB is large enough that I think connection timeout might really be an issue here... and since he already used that site in the past, we can safely ****ume he knows how to do it (which, had it been his first time, could have been the reason: e.g. problems with the site's user interface or so...).

Well, IMHO that's definitely something for Frank to look into then.

Ok Like Arnie "I'm Back!

Some answers to file sharing posted here.

http://forum.simutrans.com/index.php?topic=3476.msg34190;topicseen#msg34190

Problem would seem to be the sites, not mine.

Thanks for you reply Dirk. Incidentaly, my questions wern't meant to be as terse as they sounded.