Trouble in the convoy copy code

Topic: Trouble in the convoy copy code (Read 3471 times) previous topic - next topic

Trouble in the convoy copy code

April 01, 2010, 03:09:22 pm

OK, new bug. In a road depot, using pak Britain Ex 0.5, build a convoy with a single horse and a Stage Wagon (mail).

Then hit "copy convoy". Result: one broken convoy with * single horse * Stage Wagon (mail) * single horse * and one convoy consisting only of a Stage Wagon (mail).

This one should be fun to track down.

Re: Trouble in the convoy copy code

Reply #1 – April 01, 2010, 10:58:09 pm

It needed an additional *single horse* of a previously dis****embled convoy to reproduce this error.

Will be fixed in Simutrans Experimental 8.

The corrected simdepot.cc/.h can be found in the branch "7.2" at http://github.com/BerndGabriel/simutrans-experimental

Re: Trouble in the convoy copy code

Reply #2 – April 02, 2010, 01:57:00 pm

Neroden, thank you very much for your report, and Bernd, thank you very much for your fix - both greatly appreciated!

Re: Trouble in the convoy copy code

Reply #3 – April 02, 2010, 03:38:07 pm

Quote from: Bernd Gabriel – on April 01, 2010, 10:58:09 pm

It needed an additional *single horse* of a previously dis****embled convoy to reproduce this error.

Will be fixed in Simutrans Experimental 8.

The corrected simdepot.cc/.h can be found in the branch "7.2" at http://github.com/BerndGabriel/simutrans-experimental

Nice work!