Skip to main content ↑ ↓
Topic: ST r.2038/Pak128r153: wrong pictures for waytype icons (e.g. in line management) (Read 3748 times) previous topic - next topic

ST r.2038/Pak128r153: wrong pictures for waytype icons (e.g. in line management)

This problem appeared somewhere between Pak128 r.122 and r.150 (I don't have the ones in between on this PC), tested with r.2038-Win-SDL on W2KP.

Edit: this seems to rather be a program bug, because there are two objects with the same name, but different type, and the wrong type is used:

This defines the image that is incorrectly displayed for the trains tab:
Code: (PAK128\!base\rail_stations\dat\RailStations.dat) [Select]
Obj=building
Name=TrainStop
copyright=Jan Polacek
type=stop
waytype=track
(...)
cursor=../images/player-station_1-128.1.4

This defines the correct image:
Code: (PAK128\!base\misc_GUI_64\dat64\symbols-64.dat) [Select]
Obj=symbol
name=TrainStop
Image[0]=> ../images64/ls-symbols.1.1

Work-around would be to rename the station (but that would break existing savegames and translations) - same for the second one, the "ShipStop".

Re: ST r.2038/Pak128r153: wrong pictures for waytype icons (e.g. in line management)

Reply #1 –
Strange. Seems to work just fine here with 2038/r158 - and there were no changes in the symbols part as far as I can tell (other than a copyright entry in r154) ...
  
***** PAK128 Dev Team - semi-retired*****

Re: ST r.2038/Pak128r153: wrong pictures for waytype icons (e.g. in line management)

Reply #2 –
I guess that the effect depends on the loading sequence of objects, and that depends on pak creation and on the order of files in the pak directory. Another idea would have been a .dat error (e.g. upper-/lowercase), but the dat file hasn't changed in that regard, however, there were numerous changes to many files in Pak128, and some changes to the pak-set creation process.

Re: ST r.2038/Pak128r153: wrong pictures for waytype icons (e.g. in line management)

Reply #3 –
****. This is bad, and I wouldn't really blame program for this. Or should I? There is probably just one hash for all objects, so having objects with the same name in the first place is a mistake.

Or if objects are categorized, then it's a bug. I'll hope the situation is the latter.

Whoami: One of you can see it and the other not. I know Dirk uses the .bat from svn, how about you? If the problem can be cured in short-term by changes to how are the objects pakked, the way out should be easy.


Ah, tried it nevertheless. Rename GUI.64.pak or something like that to have underscore _ at beginning, that changes loading order and menu is fixed ;)

My projects... Tools for messing with Simutrans graphics. Graphic archive - templates and some other stuff for painters. Development logs for most recent information on what is going on. And of course pak128!

Re: ST r.2038/Pak128r153: wrong pictures for waytype icons (e.g. in line managem

Reply #4 –
Objects have a type: Thus this should not happen as stations are buildings with name ="xyz" and anhd these are symbols with this name.

EDIT: change source, that cursor objects not at root level are ignored

Re: ST r.2038/Pak128r153: wrong pictures for waytype icons (e.g. in line management)

Reply #5 –
Fixed in ST rev.2041 (actually tested: rev.2044) (Pak128 rev.159 provided a work-around).

@VS: I use Pak128 nightly builds.