The International Simutrans Forum

if(fahr[i]->gib_besch()->is_retired(month_now)  &&  welt->use_timeline())

convoi_t::get_running_cost() const
{
	sint32 running_cost = 0;
	sint32 vehicle_running_cost = 0;
        const int month_now = welt->get_timeline_year_month();
	for (unsigned i = 0; i<gib_vehikel_anzahl(); i++) { //"anzahl" = "number" (Babelfish)
		vehicle_running_cost = fahr[i]->gib_betriebskosten();  //"get_operatingCost" (Google). "Fahr" = "Drive" (Babelfish)
		if(fahr[i]->gib_besch()->is_retired(month_now)  &&  welt->use_timeline()) //If the vehicle is obsolete.
		{
			//Increase maintenance costs by amount specified in simuconf.tab.
			//This system is ugly: if anyone can make a system that calculates this smoothly, 
			//rather than in steps, then so much the better.
			sint32 extra_cost = 0;
			float multiplier = 999;
			if(!fahr[i]->gib_besch()->is_retired(month_now - 12)) //If has been obsolete for less than one year.
			{	
				multiplier = (umgebung_t::obsolete_less_1_multiplier_percent / 100);
			}
			else if(!fahr[i]->gib_besch()->is_retired(month_now - 60)) //If has been obsolete for less than five years.
			{	
				multiplier = (umgebung_t::obsolete_less_5_multiplier_percent / 100);
			}
			else if(!fahr[i]->gib_besch()->is_retired(month_now - 120)) //If has been obsolete for less than ten years.
			{	
				multiplier = (umgebung_t::obsolete_less_10_multiplier_percent / 100);
			}
			else if(!fahr[i]->gib_besch()->is_retired(month_now - 240)) //If has been obsolete for less than twenty years.
			{	
				multiplier = (umgebung_t::obsolete_less_20_multiplier_percent / 100);
			}
			else //If has been obsolete for more than 20 years
			{	
				multiplier = (umgebung_t::obsolete_more_20_multiplier_percent / 100);
			}
			extra_cost = running_cost * multiplier;
			vehicle_running_cost += extra_cost;
		}
		running_cost += vehicle_running_cost;
	}
	return running_cost;
}

#include "vehikel_besch.h"

uint16 vehikel_besch_t::gib_betriebskosten() const
{
	//@author: jamespetts
	//Running costs increased if obsolete.
	if(!welt->use_timeline() || !is_retired(month_now))	return betriebskosten;
	//Else
	uint16 base_obsolete_running_costs = (umgebung_t::obsolete_running_cost_increase_percent / 100) * betriebskosten;
	if((month_now - obsolete_date) >= (umgebung_t::obsolete_running_cost_increase_phase_years * 12)) return base_obsolete_running_costs;
	//Else
	//If not at end of phasing period, apply only a proportion of the obsolescence cost increase.
	return ((base_obsolete_running_costs - betriebskosten) * ((month_now - obsolete_date) / (umgebung_t::obsolete_running_cost_increase_phase_years * 12)) + betriebskosten;
}

void
vehikel_t::set_lookahead()
{
	route_t *route = cnv->get_route();
	int max_lookahead = (route->gib_max_n() - route_index);
	const koord3d* old_zero;
	if(lookahead[0] != lookahead[15])
	{
		old_zero = lookahead[0];
	}
	else
	{
		old_zero = NULL;
	}
	for(int i = 0; i < 15; i++)
	{
		uint8 j = i + 1;	
		int limit = (max_lookahead < 14) ? max_lookahead : 14;
		if(i <= max_lookahead)
		{				
			if(lookahead[j] == lookahead[15]) //If next item in array is empty
			{
				if(lookahead[i] != lookahead[15])
				{
					delete lookahead[i];
				}
				const koord3d *tmp;
				tmp = new const koord3d;
				tmp = &route->position_bei(route_index + i);
				//const koord3d tmp = route->position_bei(route_index + i);
				//lookahead[i] = &tmp;
				lookahead[i] = tmp;
			}
			else  //If next item in array has something in it, shunt it up one.
			{
				lookahead[i] = lookahead[j];
			}
		}
		else
		{
			lookahead[i] = lookahead[15];
		}
	}
	delete old_zero;
}

const koord3d tmp = route->position_bei(route_index + i);
lookahead[i] = &tmp;

const koord3d *tmp;
tmp = new const koord3d;
tmp = &route->position_bei(route_index + i);
lookahead[i] = tmp;

• Are you sure that all vehicles have a valid convoi?  In convoi_t, it reads "cnv != NULL falls das vehikel zu einem Convoi gehoert"
• The same question for route. Is always a valid pointer?
• I cannot understand your code without further comments, but giving a value to tmp and, afterwards, overwriting that value with the return value of route->position_bei makes no sense.  Furthermore, that memory is lost.  When you delete, you delete the original object.
• Keeping a pointer of dynamic memory across calls to your function is not very safe.  The owner of that memory can delete it when you regain control.  You should do a copy but, as you state, that copy can contain a stale route and be useless when trying to use it again.