[patch] Marker window

Topic: [patch] Marker window (Read 5469 times) previous topic - next topic

[patch] Marker window

January 19, 2009, 07:16:08 pm

New marker window with player color.
This include some fixes which don't match with label_t well.

Fixed these bugs:
- Marker changed the owner of cityroad and city buildings
- text_farbe() didn't return the color of marker owner
- Couldn't delete marker on station

Changed:
- Color of title bar is player color
- Marker list buttons have the color of marker owner
- Clicking marker list buttons don't close marker window
- Changing player close marker window

[edit] updated patch for some old games

[edit2] removed this patch. please use new one.

[attachment deleted by admin]

Re: [patch] Marker window

Reply #1 – January 19, 2009, 07:28:56 pm

Marker list add List tools?

Re: [patch] Marker window

Reply #2 – January 19, 2009, 07:41:41 pm

Quote from: Frank – on January 19, 2009, 07:28:56 pm

Marker list add List tools?

Maybe, not.
This is still not a normal list window.
When you clck ok/remove/cancel button, window will close.

I don't know the safety way to update list.
If someone can do it, please do so.

Re: [patch] Marker window

Reply #3 – January 19, 2009, 10:09:58 pm

Very good work on this.

I agree to FrankP taht all marker should be listed as stops, convois, ... player specific. And adding marker should be a special tool, and removal with the standard removal tool, as many players. The current marker system is quite hackish.

Re: [patch] Marker window

Reply #4 – January 21, 2009, 08:56:59 am

All new.
This contains some bug fixes.

To build a new marker:
- Click old marker icon on toolbar
- Click land with this tool
- A new marker info window will open, input text and hit "enter/return" key

I used wkz_marker_t for this. So, old marker window don't open anymore, sorry.

To change marker text:
- Click your marker with inspection tool
- A marker info window will open, change text and hit "enter/return" key

Yor can't change the text of other players, any more.

To remove marker text:
- Click your marker with remover tool

Removing priority is the first.

New Marker list window: dialog_tool[25]

Order: Name, Koord, Player
Filter: Active player only, Show all players

Well, we often use a marker to notice something to other players.
So, I added this filter. Default is "Active player only".

Fixed these bugs:
- Marker changed the owner of cityroad, groundobj and city buildings
- text_farbe() didn't return the color of marker owner
- Couldn't delete marker on station
- Couldn't delete marker if other player's object was build on it

[attachment deleted by admin]

Re: [patch] Marker window

Reply #5 – January 21, 2009, 10:32:40 am

Great, will test it and then include it.

Re: [patch] Marker window

Reply #6 – January 21, 2009, 11:02:04 am

After this improvement, I may use marker tool, too

Re: [patch] Marker window

Reply #7 – January 21, 2009, 01:49:32 pm

Thank you

Re: [patch] Marker window

Reply #8 – January 21, 2009, 03:02:26 pm

*claps*

Big improvement.

I liked to use markers when when I wanted to give names to districts and neighborhoods in metropolises. I'd like too see how it'll work out now.

Re: [patch] Marker window

Reply #9 – January 23, 2009, 11:08:49 pm

How do I delete a marker?

Maybe a button on the info window?

Re: [patch] Marker window

Reply #10 – January 23, 2009, 11:53:02 pm

Quote from: IgorTekton – on January 21, 2009, 03:02:26 pm

*claps*

Big improvement.

I liked to use markers when when I wanted to give names to districts and neighborhoods in metropolises. I'd like too see how it'll work out now.

Perhaps, for that function, use the public player?