Skip to main content ↑ ↓
Topic: [patch] new cursor movement (Read 35224 times) previous topic - next topic

[patch] new cursor movement

with this patch it is possible to select any ground on the map (bridges etc..)

the patch contains only the changed cursor movement, I did not touch any tools yet. So expect weird result when clicking around.
Parsley, sage, rosemary, and maggikraut.

Re: [patch] new cursor movement

Reply #1 –
Very nice patch!

It is intended, that, while pointing on a bridge, both kartenboden and bridge are highlighted?

I'm looking forward to use full 3d coordinates in the tools.

Re: [patch] new cursor movement

Reply #2 –
Quote from: gerw – on
Very nice patch!

It is intended, that, while pointing on a bridge, both kartenboden and bridge are highlighted?

thank you :)

Yes this is intended to give a hint about the height of the cursor. In fact, all levels between cursor and ground are highlighted. But on the not-marked tiles only the front part of the cursor ist shown.

Any other ideas how to indicate the 3rd coordinate visually are welcome! The method used in the old isometric game "xcom ufo defense" is my personal favourite ;)
Parsley, sage, rosemary, and maggikraut.

Re: [patch] new cursor movement

Reply #3 –
Quote from: Dwachs – on
Any other ideas how to indicate the 3rd coordinate visually are welcome! The method used in the old isometric game "xcom ufo defense" is my personal favourite ;)

I think it is a good idea. Therefore we need a new cursor, where the front vertical edge is highlighted.

For those, who don't know XCom: http://cache.kotaku.com/****ets/images/kotaku/2008/09/xcom_ufo_defense.jpg

Re: [patch] new cursor movement

Reply #4 –
Interesting.
Doesn't cursor move to on the sea yet ?

Re: [patch] new cursor movement

Reply #5 –
I though of drawing the ground with blue (yellow?) transparent color.

Re: [patch] new cursor movement

Reply #6 –
Quote from: prissi – on
I though of drawing the ground with blue (yellow?) transparent color.

could you provide more details? which ground should be transparent? the marked one? all above? all below?
Parsley, sage, rosemary, and maggikraut.

Re: [patch] new cursor movement

Reply #7 –
I mean draw a colorful overlay (orange like the marker) with the ground graphics, just like the reserved ways or stop areas on the tile the cursour actually is on.

Re: [patch] new cursor movement

Reply #8 –
Quote from: z9999 – on
Doesn't cursor move to on the sea yet ?

The termination criterion of one loop was false, I will update the patch this week.
Parsley, sage, rosemary, and maggikraut.

Re: [patch] new cursor movement

Reply #9 –
New patch file. Now all tools should work (but unexpected behaviour can be expected at some points).

Please test! :)
Parsley, sage, rosemary, and maggikraut.

Re: [patch] new cursor movement

Reply #10 –
Some impressions

- Underground mode: Can't move to empty tile. So, can't build new road/track.
- Underground mode: Too many markers with stop building tool and hard to look.
- Upgrading road/track and downgrading road/track don't use 3d coordinate.

Re: [patch] new cursor movement

Reply #11 –
This is a little bit confusing. Can it drawn in difficult colors?

F.e. From (top to bottom) red to green. So you have on top a dark red and you go to a dark green over orange or yellow. But I'm not sure if this is possible.

Re: [patch] new cursor movement

Reply #12 –
Differen colors is not possible. And 3D coordinates are not yet used, this is just preview for the changes to come to simwerkz.cc needed.

Re: [patch] new cursor movement

Reply #13 –
Quote from: z9999 – on
Some impressions
- Underground mode: Can't move to empty tile. So, can't build new road/track.
- Upgrading road/track and downgrading road/track don't use 3d coordinate.
This should be solved now.

Quote from: z9999 – on
- Underground mode: Too many markers with stop building tool and hard to look.
I changed the 'helper' marker to the grid graphics, which yield a more moderate look. Is it better?

Quote from: sojo – on
This is a little bit confusing. Can it drawn in difficult colors?
I used the marker and border graphics as defined in each pakset. At a later stage one can change this.

Quote from: prissi – on
And 3D coordinates are not yet used, this is just preview for the changes to come to simwerkz.cc needed.
The patch file contains all necessary changes, everything should be working with 3d-coordinates :o

I will ask wernieman to cross-compile the patch.
Parsley, sage, rosemary, and maggikraut.

Re: [patch] new cursor movement

Reply #15 –
First of all, thanks a lot for your great work, Dwachs. ;)

I tried the SDL/Mingw version compiled by Wernieman, and it seems that the cursor does not highlight the bridge surface at the slope end of the bridge. Is it the intended behaviour?

Re: [patch] new cursor movement

Reply #16 –
@wernieman: Thank you very matsch!

@Knightly: At least this behaviour is known. It is not easy to fix. I will try to do so this evening.
Parsley, sage, rosemary, and maggikraut.

Re: [patch] new cursor movement

Reply #17 –
Quote from: z9999 – on
- Underground mode: Too many markers with stop building tool and hard to look.
It looks better, thank you.
Quote from: z9999 – on
- Underground mode: Can't move to empty tile. So, can't build new road/track.

It works, thank you. Is it difficult to mark the same height tile ?
Currently, starting cursor popsition is on the road, but ending cursor position is on the ground. This is a little difficult to recognize.

Re: [patch] new cursor movement

Reply #18 –
Quote from: z9999 – on
- Upgrading road/track and downgrading road/track don't use 3d coordinate.
I think this still not work correctly. Can you upgrad/downgrade topmost ways ?
And also, elevated monorail could be ugpgrated to normal monorail graphics, this should not happen.

Re: [patch] new cursor movement

Reply #19 –
Regarding image ug03.png posted by z9999 above :

Would it be better if, on the ground surface, the squares above the road will also be highlighted? Those squares also fall within the coverage area of the stop.

Re: [patch] new cursor movement

Reply #20 –
Quote from: z9999 – on
Is it difficult to mark the same height tile ?
Currently, starting cursor popsition is on the road, but ending cursor position is on the ground. This is a little difficult to recognize.
yes, it is difficult. If the underground tile that should be marked is empty, there is nothing to put the cursor on.

I try to fix up- and downgrading today evening.

Quote from: Knightly – on
Regarding image ug03.png posted by z9999 above :

Would it be better if, on the ground surface, the squares above the road will also be highlighted? Those squares also fall within the coverage area of the stop.
The problem here is, that simutrans uses the same method to mark the ground where the cursor is and create the preview of the catchment area. Your proposal means that more tiles are marked, which is IMHO not a good idea. See the screenshots of z9999 above.

These difficulties in the underground view were the main motivation for me to develop the new underground view ...
Parsley, sage, rosemary, and maggikraut.

Re: [patch] new cursor movement

Reply #21 –
Quote from: z9999 – on
I think this still not work correctly. Can you upgrad/downgrade topmost ways ?

Here is a new patch file, which fixes your observations. Thank you for testing!

I included also the possibility to build elevated ways on top of elevated ways without cheating ;) Dont know whether prissi likes that or not :o
Parsley, sage, rosemary, and maggikraut.

Re: [patch] new cursor movement

Reply #23 –
Thank you!
Parsley, sage, rosemary, and maggikraut.

Re: [patch] new cursor movement

Reply #24 –
Quote from: Dwachs – on
I included also the possibility to build elevated ways on top of elevated ways without cheating ;)
Thank you. It's great, and I understand now why upgrading/downgrading topmost way didn't work.
Quote from: Dwachs – on
Dont know whether prissi likes that or not :o
Maybe... not ?  :'(
So, this cursor feature will come with height-cut mode ?
If not, there is no way to select ground tiles under bridges.

Re: [patch] new cursor movement

Reply #25 –
After integration of this cursor patch, the new underground mode will come in trunk too. We decided to first complete this patch here, the new underground mode can use all the reworked tools.

Quote from: z9999 – on
So, this cursor feature will come with height-cut mode ?
If not, there is no way to select ground tiles under bridges.

I can add support of the ctrl-key: that means ctrl+click selects the ground. What do you think? The ctrl-key is not used anymore with the cursor-patch.
Parsley, sage, rosemary, and maggikraut.

Re: [patch] new cursor movement

Reply #26 –
Will there be a new patch-Version this weekend or did you work for the trunk?

When you will make a new patch-version, then I must plan a new compilerrun ... so there will be enough tests befor you programm for the trunk.
I hope you understand my English
 

Re: [patch] new cursor movement

Reply #27 –
Quote from: Dwachs – on
I can add support of the ctrl-key: that means ctrl+click selects the ground. What do you think? The ctrl-key is not used anymore with the cursor-patch.

Well, I'm not sure which way is good, but easy way to access to behind tiles or objects would be needed for any construction tools, I think.

Re: [patch] new cursor movement

Reply #28 –
Maybe CNTRL should glue the cursor to the ground in the mouse movement routine ... that was also my suggestion when I first discussed with Daniel about this. But then of course there will be the slice mode in future.

Re: [patch] new cursor movement

Reply #29 –
new patch.

ctrl-key now selects ground. But you have to move the mouse after pressing/releasing the ctrl-key to toggle the right beaviour. I.e. simply pressing ctrl-key does not move the pointer.
Parsley, sage, rosemary, and maggikraut.

Re: [patch] new cursor movement

Reply #30 –
Why does some tools use get_grund? Especially the schedule tool should it fall back?

Re: [patch] new cursor movement

Reply #31 –
I tested the lastest version, but this version doesn't work well.

It always points ground tiles without CTRL key.
Only the magnifier icon moves up and down, but orange cursor doesn't move and always points ground tiles.
[edit]
If there are 3 height on one tile, I can select low and middle but can't select topmost height.
If there are only 2 height on one tile, I can select ground  but can't select upper height.

Re: [patch] new cursor movement

Reply #32 –
Thanks for reporting. I will look into it this weekend.
Parsley, sage, rosemary, and maggikraut.

Re: [patch] new cursor movement

Reply #33 –
I make a spezial run (see http://patches.simutrans-germany.com/)

Sorry that today and not yesterday, but yesterday my Girdfriend (and wife) think, that is more importan to play with the Laptop then to make the upload ... ;o)
I hope you understand my English